From: Felipe Balbi <me@felipebalbi.com>
To: David Brownell <david-b@pacbell.net>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
gregkh@suse.de, felipe.balbi@nokia.com,
davinci-linux-open-source@linux.davincidsp.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] musb: fix DaVinci build again
Date: Wed, 24 Dec 2008 04:27:59 +0200 [thread overview]
Message-ID: <20081224022757.GA10240@frodo> (raw)
In-Reply-To: <200812231707.48195.david-b@pacbell.net>
Hi,
just a note before a comment. I'm gonna be on vacations during this and
next week. Trying to get better from a really terrible flu so I won't be
hacking too much during this time.
Anyways, once comment below.
On Tue, Dec 23, 2008 at 05:07:47PM -0800, David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Build fixes that somehow got stripped out of the earlier build
> fix patch ...
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/usb/musb/davinci.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> --- a/drivers/usb/musb/davinci.c
> +++ b/drivers/usb/musb/davinci.c
> @@ -31,10 +31,11 @@
> #include <linux/clk.h>
> #include <linux/io.h>
> #include <linux/gpio.h>
> +#include <linux/gpio.h>
you're including <linux/gpio.h> twice.
--
balbi
next prev parent reply other threads:[~2008-12-24 2:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200812072341.50012.sshtylyov@ru.mvista.com>
[not found] ` <494A7729.6090102@ru.mvista.com>
[not found] ` <494A7809.1040504@ru.mvista.com>
[not found] ` <494E2450.9080601@ru.mvista.com>
2008-12-23 11:46 ` [PATCH] musb: fix DaVinci build again Sergei Shtylyov
2008-12-23 17:38 ` David Brownell
2008-12-23 23:23 ` Sergei Shtylyov
2008-12-24 1:07 ` David Brownell
2008-12-24 2:27 ` Felipe Balbi [this message]
2008-12-24 3:52 ` David Brownell
2008-12-25 20:37 ` David Brownell
2008-12-24 15:04 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081224022757.GA10240@frodo \
--to=me@felipebalbi.com \
--cc=david-b@pacbell.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=felipe.balbi@nokia.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox