From: Mike Frysinger <vapier@gentoo.org>
To: Adrian McMenamin <adrian@newgolddream.dyndns.info>
Cc: lkmL <linux-kernel@vger.kernel.org>,
"linux-input" <linux-input@vger.kernel.org>,
"linux-sh" <linux-sh@vger.kernel.org>,
Paul Mundt <lethal@linux-sh.org>,
Matt Fleming <matt@console-pimps.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] sh: maple: Robust checking for errors on maple keyboard initialisation
Date: Wed, 24 Dec 2008 11:59:13 -0500 [thread overview]
Message-ID: <200812241159.15332.vapier@gentoo.org> (raw)
In-Reply-To: <1229797527.6502.18.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
On Saturday 20 December 2008 13:25:27 Adrian McMenamin wrote:
> - maple_set_drvdata(mdev, NULL);
> - return error;
> +fail:
> + return -error;
same comment as for the joystick driver ... it's weird and i'm pretty sure
incorrect due to other functions setting error as well as this driver.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
prev parent reply other threads:[~2008-12-24 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-20 18:25 [PATCH] sh: maple: Robust checking for errors on maple keyboard initialisation Adrian McMenamin
2008-12-21 6:17 ` Dmitry Torokhov
2008-12-24 16:59 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812241159.15332.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=adrian@newgolddream.dyndns.info \
--cc=akpm@osdl.org \
--cc=lethal@linux-sh.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=matt@console-pimps.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox