Re: [RFC] boot parameter handling cleanup II

Ingo Molnar
2008-12-27T10:15:15Z

* Rusty Russell <rusty@rustcorp.com.au> wrote:

> (Not much change since last time, just consolidated fixes aired here, esp.
> x86 early_param fixes thanks to Hugh and Yinghai.)
>
> The following changes since commit 4a6908a3a050aacc9c3a2f36b276b46c0629ad91:
> Linus Torvalds (1):
> Linux 2.6.28
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-boot-params.git master

(it would be useful to embedd the full patch in such cases in the email -
makes for a quicker review)

> arch/x86/include/asm/cpufeature.h | 4 +-
> arch/x86/include/asm/processor.h | 3 +-
> arch/x86/kernel/cpu/common.c | 22 +++++--
> arch/x86/kernel/e820.c | 88 +++++++++++++++++----------
> arch/x86/kernel/setup.c | 41 ++++++-------
> arch/x86/mm/init_32.c | 11 ++-

no objections from the x86 perspective, as long as it does not break
stuff. If it breaks stuff it's all your fault ;-) I checked these commits:

218a372: x86: override_capabilities in early_identify_cpu
5144b68: x86: prepare noexec for being called earlier
5689919: x86: clean up setup_clear/force_cpu_cap handling
b41144e: x86: act on mem= and memmap= later in boot

and they definitely look like a step forward.

One detail: please send a pull request to Linus after the pending x86 tree
went upstream, so that there are no conflicts with existing x86 items.
There will be a (trivial) context-overlap conflict in
arch/x86/kernel/cpu/common.c.

Ingo