public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [Patch] fs/nfs/nfs4proc.c: make nfs4_map_errors() static
@ 2008-12-25 21:55 Américo Wang
  2009-01-02  0:11 ` J. Bruce Fields
  0 siblings, 1 reply; 2+ messages in thread
From: Américo Wang @ 2008-12-25 21:55 UTC (permalink / raw)
  To: LKML; +Cc: linux-nfs, Andrew Morton, bfields


nfs4_map_errors() can become static.

Signed-off-by: WANG Cong <wangcong@zeuux.org>
Cc: J. Bruce Fields <bfields@fieldses.org>

---
diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h
index ea79064..b8fb6a6 100644
--- a/fs/nfs/nfs4_fs.h
+++ b/fs/nfs/nfs4_fs.h
@@ -174,7 +174,6 @@ extern ssize_t nfs4_listxattr(struct dentry *, char *, size_t);
 
 
 /* nfs4proc.c */
-extern int nfs4_map_errors(int err);
 extern int nfs4_proc_setclientid(struct nfs_client *, u32, unsigned short, struct rpc_cred *);
 extern int nfs4_proc_setclientid_confirm(struct nfs_client *, struct rpc_cred *);
 extern int nfs4_proc_async_renew(struct nfs_client *, struct rpc_cred *);
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 83e700a..91e46ec 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -69,7 +69,7 @@ static int _nfs4_proc_lookup(struct inode *dir, const struct qstr *name, struct
 static int _nfs4_proc_getattr(struct nfs_server *server, struct nfs_fh *fhandle, struct nfs_fattr *fattr);
 
 /* Prevent leaks of NFSv4 errors into userland */
-int nfs4_map_errors(int err)
+static int nfs4_map_errors(int err)
 {
 	if (err < -1000) {
 		dprintk("%s could not handle NFSv4 error %d\n",


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] fs/nfs/nfs4proc.c: make nfs4_map_errors() static
  2008-12-25 21:55 [Patch] fs/nfs/nfs4proc.c: make nfs4_map_errors() static Américo Wang
@ 2009-01-02  0:11 ` J. Bruce Fields
  0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2009-01-02  0:11 UTC (permalink / raw)
  To: Américo Wang; +Cc: LKML, linux-nfs, Andrew Morton

On Thu, Dec 25, 2008 at 09:55:23PM +0000, Américo Wang wrote:
> 
> nfs4_map_errors() can become static.
> 
> Signed-off-by: WANG Cong <wangcong@zeuux.org>
> Cc: J. Bruce Fields <bfields@fieldses.org>

Thanks, applied for 2.6.29.--b.

> 
> ---
> diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h
> index ea79064..b8fb6a6 100644
> --- a/fs/nfs/nfs4_fs.h
> +++ b/fs/nfs/nfs4_fs.h
> @@ -174,7 +174,6 @@ extern ssize_t nfs4_listxattr(struct dentry *, char *, size_t);
>  
>  
>  /* nfs4proc.c */
> -extern int nfs4_map_errors(int err);
>  extern int nfs4_proc_setclientid(struct nfs_client *, u32, unsigned short, struct rpc_cred *);
>  extern int nfs4_proc_setclientid_confirm(struct nfs_client *, struct rpc_cred *);
>  extern int nfs4_proc_async_renew(struct nfs_client *, struct rpc_cred *);
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 83e700a..91e46ec 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -69,7 +69,7 @@ static int _nfs4_proc_lookup(struct inode *dir, const struct qstr *name, struct
>  static int _nfs4_proc_getattr(struct nfs_server *server, struct nfs_fh *fhandle, struct nfs_fattr *fattr);
>  
>  /* Prevent leaks of NFSv4 errors into userland */
> -int nfs4_map_errors(int err)
> +static int nfs4_map_errors(int err)
>  {
>  	if (err < -1000) {
>  		dprintk("%s could not handle NFSv4 error %d\n",
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-01-02  0:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-25 21:55 [Patch] fs/nfs/nfs4proc.c: make nfs4_map_errors() static Américo Wang
2009-01-02  0:11 ` J. Bruce Fields

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox