From: Ingo Molnar <mingo@elte.hu>
To: Wang Chen <wangchen@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 2/2 -tip] irq: kstat_incr_irqs_this_cpu only needs one parameter
Date: Fri, 26 Dec 2008 10:18:22 +0100 [thread overview]
Message-ID: <20081226091822.GE27747@elte.hu> (raw)
In-Reply-To: <4954A02E.3030207@cn.fujitsu.com>
* Wang Chen <wangchen@cn.fujitsu.com> wrote:
> desc is useless for kstat_incr_irqs_this_cpu.
>
> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
> ---
> arch/x86/kernel/visws_quirks.c | 2 +-
> arch/x86/xen/spinlock.c | 2 +-
> include/linux/kernel_stat.h | 3 +--
> kernel/irq/chip.c | 10 +++++-----
> kernel/irq/handle.c | 4 ++--
> 5 files changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/arch/x86/kernel/visws_quirks.c b/arch/x86/kernel/visws_quirks.c
> index 0c9667f..bd37460 100644
> --- a/arch/x86/kernel/visws_quirks.c
> +++ b/arch/x86/kernel/visws_quirks.c
> @@ -633,7 +633,7 @@ static irqreturn_t piix4_master_intr(int irq, void *dev_id)
> /*
> * handle this 'virtual interrupt' as a Cobalt one now.
> */
> - kstat_incr_irqs_this_cpu(realirq, desc);
> + kstat_incr_irqs_this_cpu(realirq);
>
> if (likely(desc->action != NULL))
> handle_IRQ_event(realirq, desc->action);
'desc' is needed in the sparseirq model:
#define kstat_incr_irqs_this_cpu(irqno, DESC) \
((DESC)->kstat_irqs[smp_processor_id()]++)
See:
http://people.redhat.com/mingo/tip.git/README
Ingo
next prev parent reply other threads:[~2008-12-26 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-26 9:13 [PATCH 2/2 -tip] irq: kstat_incr_irqs_this_cpu only needs one parameter Wang Chen
2008-12-26 9:18 ` Ingo Molnar [this message]
2008-12-26 9:44 ` Wang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081226091822.GE27747@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wangchen@cn.fujitsu.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox