* [PATCH] sysrq: fix ftrace help msg & doc.
@ 2008-12-25 0:06 Randy Dunlap
2008-12-26 9:28 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2008-12-25 0:06 UTC (permalink / raw)
To: lkml; +Cc: akpm, Steven Rostedt, Ingo Molnar
From: Randy Dunlap <randy.dunlap@oracle.com>
We have a conventional method of explicitly stating the
sysrq action key in a sysrq help message, so change
dump-ftrace-buffer to use that method and add it to
Documentation/sysrq.txt.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Steven Rostedt <rostedt@goodmis.org>
cc: Ingo Molnar <mingo@elte.hu>
---
Documentation/sysrq.txt | 2 ++
drivers/char/sysrq.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
--- mmotm-2008-1224-0120.orig/drivers/char/sysrq.c
+++ mmotm-2008-1224-0120/drivers/char/sysrq.c
@@ -283,7 +283,7 @@ static void sysrq_ftrace_dump(int key, s
}
static struct sysrq_key_op sysrq_ftrace_dump_op = {
.handler = sysrq_ftrace_dump,
- .help_msg = "dumpZ-ftrace-buffer",
+ .help_msg = "dump-ftrace-buffer(Z)",
.action_msg = "Dump ftrace buffer",
.enable_mask = SYSRQ_ENABLE_DUMP,
};
--- mmotm-2008-1224-0120.orig/Documentation/sysrq.txt
+++ mmotm-2008-1224-0120/Documentation/sysrq.txt
@@ -114,6 +114,8 @@ On all - write a character to /proc/sys
'x' - Used by xmon interface on ppc/powerpc platforms.
+'z' - Dump the ftrace buffer
+
'0'-'9' - Sets the console log level, controlling which kernel messages
will be printed to your console. ('0', for example would make
it so that only emergency messages like PANICs or OOPSes would
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sysrq: fix ftrace help msg & doc.
2008-12-25 0:06 [PATCH] sysrq: fix ftrace help msg & doc Randy Dunlap
@ 2008-12-26 9:28 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-12-26 9:28 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, akpm, Steven Rostedt
* Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> We have a conventional method of explicitly stating the
> sysrq action key in a sysrq help message, so change
> dump-ftrace-buffer to use that method and add it to
> Documentation/sysrq.txt.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc: Steven Rostedt <rostedt@goodmis.org>
> cc: Ingo Molnar <mingo@elte.hu>
> ---
> Documentation/sysrq.txt | 2 ++
> drivers/char/sysrq.c | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
applied to tip/tracing/docs, thanks Randy!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-26 9:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-25 0:06 [PATCH] sysrq: fix ftrace help msg & doc Randy Dunlap
2008-12-26 9:28 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox