From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh Rajput <jaswinder@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
perfctr-devel@lists.sourceforge.net
Subject: Re: [PATCH] x86: perf_counter remove unwanted hw_perf_enable_all
Date: Sat, 27 Dec 2008 16:02:29 +0100 [thread overview]
Message-ID: <20081227150229.GA19595@elte.hu> (raw)
In-Reply-To: <1230385543.3373.5.camel@jaswinder.satnam>
* Jaswinder Singh Rajput <jaswinder@infradead.org> wrote:
> Impact: clean, reduce kernel size a bit, avoid sparse warnings
>
> Fixes sparse warnings:
>
> arch/x86/kernel/cpu/perf_counter.c:153:6: warning: symbol 'hw_perf_enable_all' was not declared. Should it be static?
> arch/x86/kernel/cpu/perf_counter.c:279:3: warning: returning void-valued expression
> arch/x86/kernel/cpu/perf_counter.c:206:3: warning: returning void-valued expression
> arch/x86/kernel/cpu/perf_counter.c:206:3: warning: returning void-valued expression
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> arch/x86/kernel/cpu/perf_counter.c | 24 +++++++-----------------
> 1 files changed, 7 insertions(+), 17 deletions(-)
applied to tip/perfcounters/core, thanks!
Ingo
prev parent reply other threads:[~2008-12-27 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-27 13:45 [PATCH] x86: perf_counter remove unwanted hw_perf_enable_all Jaswinder Singh Rajput
2008-12-27 15:02 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081227150229.GA19595@elte.hu \
--to=mingo@elte.hu \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perfctr-devel@lists.sourceforge.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox