From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com,
linux-kernel@vger.kernel.org,
Patrick Boettcher <patrick.boettcher@desy.de>
Subject: Re: [GIT PATCHES for 2.6.28] V4L/DVB fixes, crash in af9005_usb_module_init()
Date: Sat, 27 Dec 2008 20:11:22 +0300 [thread overview]
Message-ID: <20081227171122.GA20147@localhost> (raw)
In-Reply-To: <20081227164020.GA9726@elte.hu>
[Ingo Molnar - Sat, Dec 27, 2008 at 05:40:20PM +0100]
|
| * Ingo Molnar <mingo@elte.hu> wrote:
|
| > [...] I have re-enabled the driver in tip/master [...]
|
| ok, just got this build failure:
|
| drivers/built-in.o: In function `dm1105_probe':
| dm1105.c:(.devinit.text+0x2298b): undefined reference to `cx24116_attach'
| make: *** [.tmp_vmlinux1] Error 1
|
| config attached. Can test any fix patch.
|
| Ingo
|
Something like that?
- Cyrill -
---
drivers/media/dvb/frontends/cx24116.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6.git/drivers/media/dvb/frontends/cx24116.h
===================================================================
--- linux-2.6.git.orig/drivers/media/dvb/frontends/cx24116.h
+++ linux-2.6.git/drivers/media/dvb/frontends/cx24116.h
@@ -37,7 +37,8 @@ struct cx24116_config {
u8 mpg_clk_pos_pol:0x02;
};
-#if defined(CONFIG_DVB_CX24116) || defined(CONFIG_DVB_CX24116_MODULE)
+#if defined(CONFIG_DVB_CX24116) || \
+ (defined(CONFIG_DVB_CX24116_MODULE) && defined(MODULE))
extern struct dvb_frontend *cx24116_attach(
const struct cx24116_config *config,
struct i2c_adapter *i2c);
next prev parent reply other threads:[~2008-12-27 17:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-24 14:12 [GIT PATCHES for 2.6.28] V4L/DVB fixes Mauro Carvalho Chehab
2008-12-25 8:19 ` Ingo Molnar
2008-12-25 10:30 ` Ingo Molnar
2008-12-26 13:08 ` Mauro Carvalho Chehab
2008-12-26 15:38 ` Luca Olivetti
2008-12-25 23:24 ` Mauro Carvalho Chehab
2008-12-26 9:02 ` Ingo Molnar
2008-12-26 13:13 ` Mauro Carvalho Chehab
2008-12-26 13:24 ` [GIT PATCHES for 2.6.28] V4L/DVB fixes, crash in af9005_usb_module_init() Ingo Molnar
2008-12-26 13:45 ` Mauro Carvalho Chehab
2008-12-27 12:00 ` [patch] fix warning in drivers/media/dvb/dvb-usb/af9005-fe.c Ingo Molnar
2008-12-27 20:24 ` [v4l-dvb-maintainer] " Andy Walls
2008-12-30 19:49 ` Mauro Carvalho Chehab
2008-12-27 16:40 ` [GIT PATCHES for 2.6.28] V4L/DVB fixes, crash in af9005_usb_module_init() Ingo Molnar
2008-12-27 17:11 ` Cyrill Gorcunov [this message]
2008-12-27 17:19 ` Cyrill Gorcunov
2008-12-27 18:01 ` Cyrill Gorcunov
2008-12-30 19:33 ` Mauro Carvalho Chehab
2008-12-30 19:40 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081227171122.GA20147@localhost \
--to=gorcunov@gmail.com \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mingo@elte.hu \
--cc=patrick.boettcher@desy.de \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox