From: Evgeniy Dushistov <dushistov@mail.ru>
To: Nick Piggin <npiggin@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] minix: fix add link - wrong position calculation
Date: Mon, 29 Dec 2008 02:25:50 +0300 [thread overview]
Message-ID: <20081228232550.GA11504@rain> (raw)
This patch fixes add link method.
Position in directory was calculated in wrong way.
Signed-off-by: Evgeniy Dushistov <dushistov@mail.ru>
---
fs/minix/dir.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/minix/dir.c b/fs/minix/dir.c
index f704338..4b603b7 100644
--- a/fs/minix/dir.c
+++ b/fs/minix/dir.c
@@ -280,7 +280,7 @@ int minix_add_link(struct dentry *dentry, struct inode *inode)
return -EINVAL;
got_it:
- pos = (page->index >> PAGE_CACHE_SHIFT) + p - (char*)page_address(page);
+ pos = page_offset(page) + p - (char*)page_address(page);
err = __minix_write_begin(NULL, page->mapping, pos, sbi->s_dirsize,
AOP_FLAG_UNINTERRUPTIBLE, &page, NULL);
if (err)
--
1.6.0.6
--
/Evgeniy
next reply other threads:[~2008-12-28 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-28 23:25 Evgeniy Dushistov [this message]
2008-12-30 23:32 ` [PATCH] minix: fix add link - wrong position calculation Andrew Morton
2008-12-31 1:26 ` Nick Piggin
2008-12-31 1:49 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081228232550.GA11504@rain \
--to=dushistov@mail.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox