From: Mike Frysinger <vapier@gentoo.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, Ingo Molnar <mingo@elte.hu>,
tglx@linutronix.de, mingo@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace
Date: Mon, 29 Dec 2008 06:56:31 -0500 [thread overview]
Message-ID: <200812290656.32827.vapier@gentoo.org> (raw)
In-Reply-To: <495699A0.10305@zytor.com>
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
On Saturday 27 December 2008 16:09:52 H. Peter Anvin wrote:
> Mike Frysinger wrote:
> > ...
> > #ifdef __KERNEL__
> > # define kernel_flock flock
> > #endif
> > struct kernel_flock {
> > ...
>
> FWIW, a long time ago I proposed the __kabi_ prefix for these things; I
> think it is a good thing to make userspace-visible structures stand out
> even in the kernel code itself.
>
> As such, I would suggest *not* adding the #define at all.
the convention based on linux/types.h seems to be to use __kernel_ as the
prefix, but it doesnt matter to me whether it's __kabi_ or __kernel_. i'll
start doing the latter though in the hopes it'll be less scary ;).
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2008-12-29 11:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-27 6:50 [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace Mike Frysinger
2008-12-27 7:12 ` Sam Ravnborg
2008-12-27 7:55 ` Mike Frysinger
2008-12-27 8:47 ` Ingo Molnar
2008-12-27 9:21 ` Mike Frysinger
2008-12-27 18:57 ` Sam Ravnborg
2008-12-27 18:58 ` H. Peter Anvin
2008-12-27 19:12 ` Sam Ravnborg
2008-12-27 19:15 ` H. Peter Anvin
2008-12-27 19:21 ` Mike Frysinger
2008-12-27 19:23 ` H. Peter Anvin
2008-12-27 20:05 ` Mike Frysinger
2008-12-27 20:45 ` H. Peter Anvin
2008-12-27 20:57 ` Mike Frysinger
2008-12-27 21:08 ` H. Peter Anvin
2008-12-27 21:09 ` H. Peter Anvin
2008-12-29 11:56 ` Mike Frysinger [this message]
2008-12-29 17:44 ` H. Peter Anvin
2008-12-27 19:24 ` Sam Ravnborg
2008-12-27 19:24 ` H. Peter Anvin
2008-12-29 11:12 ` [PATCH] kbuild: auto-convert size types in userspace headers Mike Frysinger
2008-12-29 14:03 ` Sam Ravnborg
2008-12-29 20:34 ` Mike Frysinger
2008-12-29 20:36 ` H. Peter Anvin
2008-12-29 22:04 ` Mike Frysinger
2008-12-29 23:35 ` H. Peter Anvin
2008-12-30 10:43 ` Sam Ravnborg
2008-12-30 17:42 ` H. Peter Anvin
2009-01-18 20:53 ` Sam Ravnborg
2009-01-07 16:44 ` [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace David Woodhouse
2008-12-27 21:15 ` H. Peter Anvin
2008-12-28 22:35 ` Marcin Slusarz
2008-12-28 23:03 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812290656.32827.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox