From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Subject: Re: [git pull] sparseirq / irq updates for v2.6.29
Date: Mon, 29 Dec 2008 10:44:34 +0100 [thread overview]
Message-ID: <20081229094434.GD27293@elte.hu> (raw)
In-Reply-To: <49581F6E.6010205@kernel.org>
* Yinghai Lu <yinghai@kernel.org> wrote:
> int __init __weak arch_early_irq_init(void)
> {
> + printk(KERN_DEBUG "calling __weak arch_early_irq_init()\n");
Hm, where do you get the idea that sprinkling functions with printks will
in any way improve the situation and result in clean code? Yes, it works
around the bug, but so will an infinite number of other things.
By far the best solution is to move them into a different compilation unit
- i.e. your first patch - i'll apply that one.
Ingo
next prev parent reply other threads:[~2008-12-29 9:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-25 16:07 [git pull] sparseirq / irq updates for v2.6.29 Ingo Molnar
2008-12-27 13:32 ` Ingo Molnar
2008-12-27 17:27 ` KOSAKI Motohiro
2008-12-27 17:38 ` Ingo Molnar
2008-12-28 23:11 ` Linus Torvalds
2008-12-28 23:23 ` Yinghai Lu
2008-12-28 23:27 ` Ingo Molnar
2008-12-28 23:30 ` Ingo Molnar
2008-12-29 0:01 ` Yinghai Lu
2008-12-29 8:39 ` KOSAKI Motohiro
2008-12-29 11:09 ` Ingo Molnar
2008-12-29 11:20 ` KOSAKI Motohiro
2008-12-29 0:28 ` Yinghai Lu
2008-12-29 0:53 ` Yinghai Lu
2008-12-29 9:44 ` Ingo Molnar [this message]
2008-12-29 9:52 ` Ingo Molnar
2008-12-29 11:00 ` Kamalesh Babulal
2008-12-29 11:05 ` Ingo Molnar
2008-12-29 16:05 ` Kamalesh Babulal
2008-12-29 16:20 ` Ingo Molnar
2008-12-29 16:22 ` KOSAKI Motohiro
2008-12-29 16:36 ` Ingo Molnar
2008-12-28 23:55 ` H. Peter Anvin
2008-12-29 0:06 ` Yinghai Lu
2008-12-29 0:38 ` H. Peter Anvin
2008-12-29 9:34 ` Ingo Molnar
2008-12-28 23:10 ` [git pull] sparseirq / irq fixes Ingo Molnar
2008-12-29 12:52 ` Ingo Molnar
2008-12-31 0:22 ` Linus Torvalds
2008-12-31 6:48 ` Ingo Molnar
2008-12-31 12:00 ` [sparseirq] remove debug printks (io_apic.c) Markus Trippelsdorf
2009-01-02 22:21 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081229094434.GD27293@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox