Re: [git pull] sparseirq / irq updates for v2.6.29

Ingo Molnar
2008-12-29T09:45:14Z

* Yinghai Lu <yinghai@kernel.org> wrote:

> int __init __weak arch_early_irq_init(void)
> {
> + printk(KERN_DEBUG "calling __weak arch_early_irq_init()\n");

Hm, where do you get the idea that sprinkling functions with printks will
in any way improve the situation and result in clean code? Yes, it works
around the bug, but so will an infinite number of other things.

By far the best solution is to move them into a different compilation unit
- i.e. your first patch - i'll apply that one.

Ingo