From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh Rajput <jaswinder@infradead.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
mj@ucw.cz
Subject: Re: [PATCH] move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h
Date: Mon, 29 Dec 2008 11:07:46 +0100 [thread overview]
Message-ID: <20081229100746.GA12159@elte.hu> (raw)
In-Reply-To: <1230537538.3090.4.camel@jaswinder.satnam>
* Jaswinder Singh Rajput <jaswinder@infradead.org> wrote:
> On Mon, 2008-12-29 at 09:57 +0300, Alexey Dobriyan wrote:
> > On Sat, Dec 27, 2008 at 06:32:28PM +0530, Jaswinder Singh Rajput wrote:
> > > Impact: cleanup, arch/x86/pci/pci.h -> arch/x86/include/asm/pci_x86.h
> >
> > And this is done for what?
>
> Don't you think arch/x86/pci/pci.h looks ugly it should be in
> arch/x86/incluse/asm directory ?
>
> It was suggested by Ingo :
> http://marc.info/?l=linux-kernel&m=123037395221921&w=2
>
> I think Ingo will have more valid reasons to satisfy your curiousity ;-)
yes - the reason why i asked for that is that asm/pci.h already exists,
and it is included in generic code (via linux/include/pci.h) and provides
public PCI interfaces.
pci_x86.h (a'ka arch/x86/pci/pci.h) includes lowlevel x86-only internals,
included from a handful PCI arch/x86/ platform .c files.
Ingo
next prev parent reply other threads:[~2008-12-29 10:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-27 13:02 [PATCH] move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h Jaswinder Singh Rajput
2008-12-29 6:57 ` Alexey Dobriyan
2008-12-29 7:58 ` Jaswinder Singh Rajput
2008-12-29 8:48 ` Alexey Dobriyan
2008-12-29 10:01 ` H. Peter Anvin
2008-12-29 10:07 ` Ingo Molnar [this message]
2008-12-29 12:12 ` Ingo Molnar
2008-12-29 12:22 ` Ingo Molnar
2008-12-29 12:41 ` Jaswinder Singh Rajput
2008-12-29 12:54 ` Sam Ravnborg
2008-12-29 12:59 ` Ingo Molnar
2008-12-29 13:01 ` Ingo Molnar
2008-12-29 13:25 ` Sam Ravnborg
2008-12-29 14:10 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081229100746.GA12159@elte.hu \
--to=mingo@elte.hu \
--cc=adobriyan@gmail.com \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mj@ucw.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox