Re: [PATCH] x86: reboot.c declare port_cf9_safe before they get used

[Ingo Molnar <mingo@elte.hu>]

* Jaswinder Singh Rajput <jaswinder@infradead.org> wrote:

> Hello Ingo,
> 
> On Sat, 2008-12-27 at 11:31 +0100, Ingo Molnar wrote:
> 
> > btw., this is ugly now:
> > 
> > > --- a/arch/x86/kernel/reboot.c
> > > +++ b/arch/x86/kernel/reboot.c
> > > @@ -22,6 +22,7 @@
> > >  #endif
> > >  
> > >  #include <mach_ipi.h>
> > > +#include "../pci/pci.h"
> > 
> > could you send another patch that moves arch/x86/pci/pci.h to 
> > arch/x86/include/asm/pci_x86.h (and update all the pci.h include sites)?
> > 
> 
> 1. I send [PATCH] move arch/x86/pci/pci.h to
> arch/x86/include/asm/pci_x86.h but I forget to write x86: before this
> patch.

no, your patch is fine. I routinely fix up commit logs.

Jesse, is it fine to you if we push this via the x86 tree? A couple of 
usage sites of arch/x86/pci/pci.h arose that use ../pci/pci.h kind of ugly
#include prefixes, which justifies moving the file to
arch/x86/include/asm. No change in behavior.

	Ingo