[PATCH -tip] x86: mach-default setup.c cleanup

[PATCH -tip] x86: mach-default setup.c cleanup

[Cyrill Gorcunov]

Impact: cleanup

Break THAT long lines into shorter form.
Use pr_ macros instead of plain printk.

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---

Nothing serious except loglevel of messages being
printed is changed (was KERN_WARNING as by default).
Yeah, it's not-fixing-anything-patch, so feel free
to just drop it if it break a patch queue :-)

 arch/x86/mach-default/setup.c |   15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

Index: linux-2.6.git/arch/x86/mach-default/setup.c
===================================================================
--- linux-2.6.git.orig/arch/x86/mach-default/setup.c
+++ linux-2.6.git/arch/x86/mach-default/setup.c
@@ -133,29 +133,28 @@ void __init time_init_hook(void)
  **/
 void mca_nmi_hook(void)
 {
-	/* If I recall correctly, there's a whole bunch of other things that
+	/*
+	 * If I recall correctly, there's a whole bunch of other things that
 	 * we can do to check for NMI problems, but that's all I know about
 	 * at the moment.
 	 */
-
-	printk("NMI generated from unknown source!\n");
+	pr_warning("NMI generated from unknown source!\n");
 }
 #endif
 
 static __init int no_ipi_broadcast(char *str)
 {
 	get_option(&str, &no_broadcast);
-	printk ("Using %s mode\n", no_broadcast ? "No IPI Broadcast" :
-											"IPI Broadcast");
+	pr_info("Using %s mode\n",
+		no_broadcast ? "No IPI Broadcast" : "IPI Broadcast");
 	return 1;
 }
-
 __setup("no_ipi_broadcast=", no_ipi_broadcast);
 
 static int __init print_ipi_mode(void)
 {
-	printk ("Using IPI %s mode\n", no_broadcast ? "No-Shortcut" :
-											"Shortcut");
+	pr_info("Using IPI %s mode\n",
+		no_broadcast ? "No-Shortcut" : "Shortcut");
 	return 0;
 }
 

Re: [PATCH -tip] x86: mach-default setup.c cleanup

[Ingo Molnar]

* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> Impact: cleanup
> 
> Break THAT long lines into shorter form.
> Use pr_ macros instead of plain printk.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
> 
> Nothing serious except loglevel of messages being
> printed is changed (was KERN_WARNING as by default).
> Yeah, it's not-fixing-anything-patch, so feel free
> to just drop it if it break a patch queue :-)
> 
>  arch/x86/mach-default/setup.c |   15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)

applied to tip/x86/cleanups, thanks Cyrill!

	Ingo