public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jaswinder Singh Rajput <jaswinder@infradead.org>,
	x86 maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	mj@ucw.cz
Subject: Re: [PATCH] move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h
Date: Mon, 29 Dec 2008 13:54:11 +0100	[thread overview]
Message-ID: <20081229125411.GA1852@uranus.ravnborg.org> (raw)
In-Reply-To: <20081229122251.GA13687@elte.hu>

> 
> btw., you missed to update a couple of places - pci/pci.h was used outside 
> of arch/x86 as well. Updated patch below.
> 
> 	Ingo
> 
> ---------------->
> >From 54a090abe7cb85c724305124f57d2570b7e9adf1 Mon Sep 17 00:00:00 2001
> From: Jaswinder Singh Rajput <jaswinder@infradead.org>
> Date: Sat, 27 Dec 2008 18:32:28 +0530
> Subject: [PATCH] x86, pci: move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h
> 
> Impact: cleanup
> 
> Now that arch/x86/pci/pci.h is used in a number of other places as well,
> move the lowlevel x86 pci definitions into the architecture include files.
> (not to be confused with the existing arch/x86/include/asm/pci.h file,
> which provides public details about x86 PCI)
> 
> Tested on: X86_32_UP, X86_32_SMP and X86_64_SMP
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
>  arch/x86/include/asm/pci_x86.h     |  165 ++++++++++++++++++++++++++++++++++++
>  arch/x86/kernel/mmconf-fam10h_64.c |    3 +-
>  arch/x86/kernel/reboot.c           |    3 +-
>  arch/x86/pci/acpi.c                |    2 +-
>  arch/x86/pci/amd_bus.c             |    2 +-
>  arch/x86/pci/common.c              |    3 +-
>  arch/x86/pci/direct.c              |    2 +-
>  arch/x86/pci/early.c               |    2 +-
>  arch/x86/pci/fixup.c               |    3 +-
>  arch/x86/pci/i386.c                |    2 +-
>  arch/x86/pci/init.c                |    2 +-
>  arch/x86/pci/irq.c                 |    3 +-
>  arch/x86/pci/legacy.c              |    2 +-
>  arch/x86/pci/mmconfig-shared.c     |    3 +-
>  arch/x86/pci/mmconfig_32.c         |    2 +-
>  arch/x86/pci/mmconfig_64.c         |    3 +-
>  arch/x86/pci/numaq_32.c            |    2 +-
>  arch/x86/pci/olpc.c                |    2 +-
>  arch/x86/pci/pcbios.c              |    5 +-
>  arch/x86/pci/pci.h                 |  162 -----------------------------------
>  arch/x86/pci/visws.c               |    3 +-
>  drivers/pci/hotplug/cpqphp_core.c  |    2 +-
>  drivers/pci/hotplug/cpqphp_pci.c   |    2 +-
>  drivers/pci/hotplug/ibmphp_core.c  |    2 +-
>  24 files changed, 188 insertions(+), 194 deletions(-)

You should teach your script to use:
git format-patch -M -B -C 

With -M -B -C you get a much better picture of what happens when you rename
files like in this patch (and copy them).

	Sam

  parent reply	other threads:[~2008-12-29 12:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-27 13:02 [PATCH] move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h Jaswinder Singh Rajput
2008-12-29  6:57 ` Alexey Dobriyan
2008-12-29  7:58   ` Jaswinder Singh Rajput
2008-12-29  8:48     ` Alexey Dobriyan
2008-12-29 10:01       ` H. Peter Anvin
2008-12-29 10:07     ` Ingo Molnar
2008-12-29 12:12 ` Ingo Molnar
2008-12-29 12:22   ` Ingo Molnar
2008-12-29 12:41     ` Jaswinder Singh Rajput
2008-12-29 12:54     ` Sam Ravnborg [this message]
2008-12-29 12:59       ` Ingo Molnar
2008-12-29 13:01         ` Ingo Molnar
2008-12-29 13:25           ` Sam Ravnborg
2008-12-29 14:10             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081229125411.GA1852@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=jaswinder@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mj@ucw.cz \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox