* [PATCH] x86: io_apic.c io_apic_sync should be static
@ 2008-12-29 15:04 Jaswinder Singh Rajput
2008-12-29 15:24 ` Cyrill Gorcunov
0 siblings, 1 reply; 2+ messages in thread
From: Jaswinder Singh Rajput @ 2008-12-29 15:04 UTC (permalink / raw)
To: Ingo Molnar, x86 maintainers, LKML
Impact: cleanup, reduce kernel size a bit, avoid sparse warning
Fixes sparse warning:
arch/x86/kernel/io_apic.c:709:6: warning: symbol 'io_apic_sync' was not declared. Should it be static?
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kernel/io_apic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/io_apic.c b/arch/x86/kernel/io_apic.c
index 62ecfc9..6991172 100644
--- a/arch/x86/kernel/io_apic.c
+++ b/arch/x86/kernel/io_apic.c
@@ -706,7 +706,7 @@ static void __unmask_IO_APIC_irq(struct irq_cfg *cfg)
}
#ifdef CONFIG_X86_64
-void io_apic_sync(struct irq_pin_list *entry)
+static void io_apic_sync(struct irq_pin_list *entry)
{
/*
* Synchronize the IO-APIC and the CPU by doing
--
1.5.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: io_apic.c io_apic_sync should be static
2008-12-29 15:04 [PATCH] x86: io_apic.c io_apic_sync should be static Jaswinder Singh Rajput
@ 2008-12-29 15:24 ` Cyrill Gorcunov
0 siblings, 0 replies; 2+ messages in thread
From: Cyrill Gorcunov @ 2008-12-29 15:24 UTC (permalink / raw)
To: Jaswinder Singh Rajput; +Cc: Ingo Molnar, x86 maintainers, LKML
[Jaswinder Singh Rajput - Mon, Dec 29, 2008 at 08:34:35PM +0530]
| Impact: cleanup, reduce kernel size a bit, avoid sparse warning
|
| Fixes sparse warning:
| arch/x86/kernel/io_apic.c:709:6: warning: symbol 'io_apic_sync' was not declared. Should it be static?
|
| Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
| ---
| arch/x86/kernel/io_apic.c | 2 +-
| 1 files changed, 1 insertions(+), 1 deletions(-)
|
| diff --git a/arch/x86/kernel/io_apic.c b/arch/x86/kernel/io_apic.c
| index 62ecfc9..6991172 100644
| --- a/arch/x86/kernel/io_apic.c
| +++ b/arch/x86/kernel/io_apic.c
| @@ -706,7 +706,7 @@ static void __unmask_IO_APIC_irq(struct irq_cfg *cfg)
| }
|
| #ifdef CONFIG_X86_64
| -void io_apic_sync(struct irq_pin_list *entry)
| +static void io_apic_sync(struct irq_pin_list *entry)
| {
| /*
| * Synchronize the IO-APIC and the CPU by doing
| --
| 1.5.5.1
Thanks Jaswinder! It should be static.
- Cyrill -
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-29 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-29 15:04 [PATCH] x86: io_apic.c io_apic_sync should be static Jaswinder Singh Rajput
2008-12-29 15:24 ` Cyrill Gorcunov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox