From: Mike Frysinger <vapier@gentoo.org>
To: Adrian McMenamin <adrian@newgolddream.dyndns.info>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-sh" <linux-sh@vger.kernel.org>,
"linux-input" <linux-input@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH] sh: maple: add support for the Maple mouse on the SEGA Dreamcast
Date: Mon, 29 Dec 2008 16:36:34 -0500 [thread overview]
Message-ID: <200812291636.36303.vapier@gentoo.org> (raw)
In-Reply-To: <1230586215.6496.28.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
On Monday 29 December 2008 16:30:14 Adrian McMenamin wrote:
> +static int __devexit remove_maple_mouse(struct device *dev)
> +static struct maple_driver dc_mouse_driver = {
> + .drv = {
> + .remove = remove_maple_mouse,
does that really build warning free ? usually you need __devexit_p() in the
.remove assignment ...
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2008-12-29 21:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 19:17 [PATCH] sh: maple: add support for the Maple mouse on the SEGA Dreamcast Adrian McMenamin
2008-12-29 21:02 ` Mike Frysinger
2008-12-29 21:30 ` Adrian McMenamin
2008-12-29 21:36 ` Mike Frysinger [this message]
2008-12-29 21:38 ` Adrian McMenamin
2008-12-29 21:46 ` Sam Ravnborg
2008-12-29 22:17 ` Adrian McMenamin
2008-12-29 22:19 ` Mike Frysinger
2008-12-30 8:17 ` Dmitry Torokhov
2008-12-30 20:27 ` Adrian McMenamin
2009-01-01 7:41 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812291636.36303.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=adrian@newgolddream.dyndns.info \
--cc=akpm@osdl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox