From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/14] kmemleak: Add the base support
Date: Tue, 30 Dec 2008 08:38:07 +0100 [thread overview]
Message-ID: <20081230073807.GA2455@elte.hu> (raw)
In-Reply-To: <20081229162314.1cc7a549.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> > +/*
> > + * Stop the automatic memory scanning thread. This function must be called
> > + * with the kmemleak_mutex held.
> > + */
> > +void stop_scan_thread(void)
> > +{
> > + if (scan_thread) {
> > + kthread_stop(scan_thread);
> > + scan_thread = NULL;
> > + }
> > +}
>
> so... why do we need a kernel thread?
>
> We could have (for the sake of argument) a sys_kmemleak_scan() which
> does a single scan then returns. Or something like that. That way,
> userspace directly gets to set the scanning frequency, thread priority,
> etc.
thread priority of a kernel thread can be set anyway. Kernel threads tend
to be better for such simple things because we can control all aspects,
start them automatically so that test setups catch it (without needing any
userspace component), etc.
Ingo
next prev parent reply other threads:[~2008-12-30 7:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 18:12 [PATCH 00/14] Kernel memory leak detector Catalin Marinas
2008-12-19 18:13 ` [PATCH 01/14] kmemleak: Add the base support Catalin Marinas
2008-12-19 20:08 ` Pekka Enberg
2008-12-19 22:02 ` Ingo Molnar
2008-12-19 22:14 ` Andrew Morton
2008-12-22 13:05 ` Catalin Marinas
2008-12-30 0:23 ` Andrew Morton
2008-12-30 7:38 ` Ingo Molnar [this message]
2008-12-30 7:44 ` Andrew Morton
2008-12-30 7:52 ` Ingo Molnar
2008-12-30 7:59 ` Andrew Morton
2008-12-30 10:48 ` Catalin Marinas
2008-12-19 18:13 ` [PATCH 02/14] kmemleak: Add documentation on the memory leak detector Catalin Marinas
2008-12-19 18:30 ` Randy Dunlap
2008-12-19 18:13 ` [PATCH 03/14] kmemleak: Add the slab memory allocation/freeing hooks Catalin Marinas
2008-12-19 20:05 ` Pekka Enberg
2008-12-19 18:13 ` [PATCH 04/14] kmemleak: Add the slob " Catalin Marinas
2008-12-19 18:13 ` [PATCH 05/14] kmemleak: Add the slub " Catalin Marinas
2008-12-19 20:05 ` Pekka Enberg
2008-12-19 18:13 ` [PATCH 06/14] kmemleak: Add the vmalloc " Catalin Marinas
2008-12-19 18:13 ` [PATCH 07/14] kmemleak: Add kmemleak_alloc callback from alloc_large_system_hash Catalin Marinas
2008-12-19 18:13 ` [PATCH 08/14] kmemleak: Add modules support Catalin Marinas
2008-12-19 18:13 ` [PATCH 09/14] x86: Provide _sdata in the vmlinux_*.lds.S files Catalin Marinas
2008-12-19 18:13 ` [PATCH 10/14] arm: Provide _sdata and __bss_stop in the vmlinux.lds.S file Catalin Marinas
2008-12-19 18:13 ` [PATCH 11/14] kmemleak: Remove some of the kmemleak false positives Catalin Marinas
2008-12-19 20:15 ` Pekka Enberg
2008-12-22 12:04 ` Catalin Marinas
2008-12-19 18:14 ` [PATCH 12/14] kmemleak: Enable the building of the memory leak detector Catalin Marinas
2008-12-19 18:14 ` [PATCH 13/14] kmemleak: Simple testing module for kmemleak Catalin Marinas
2008-12-19 18:14 ` [PATCH 14/14] kmemleak: Add the corresponding MAINTAINERS entry Catalin Marinas
2008-12-30 0:23 ` [PATCH 00/14] Kernel memory leak detector Andrew Morton
2008-12-30 11:43 ` Catalin Marinas
2009-01-08 22:45 ` Andrew Morton
2009-01-12 9:51 ` Catalin Marinas
2009-01-12 10:21 ` Andrew Morton
2009-01-12 10:33 ` Stephen Rothwell
2009-01-12 11:13 ` Catalin Marinas
2009-01-14 12:30 ` Catalin Marinas
2009-01-14 14:01 ` Stephen Rothwell
2009-01-14 14:50 ` Catalin Marinas
2009-01-15 22:09 ` Mike Snitzer
2009-01-16 9:22 ` Catalin Marinas
-- strict thread matches above, loose matches on Subject: below --
2009-04-24 16:40 Catalin Marinas
2009-04-24 16:41 ` [PATCH 01/14] kmemleak: Add the base support Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081230073807.GA2455@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox