From: Frederic Weisbecker <fweisbec@gmail.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
mingo@elte.hu
Subject: Re: [PATCH] tracing/kmemtrace: normalize the raw tracer event to the unified tracing API
Date: Tue, 30 Dec 2008 15:32:21 +0100 [thread overview]
Message-ID: <20081230143221.GC5722@nowhere> (raw)
In-Reply-To: <1230623364.6091.9.camel@penberg-laptop>
On Tue, Dec 30, 2008 at 09:49:24AM +0200, Pekka Enberg wrote:
> Hi Frederic,
>
> On Mon, 2008-12-29 at 23:09 +0100, Frederic Weisbecker wrote:
> > Pekka, note that I would be pleased to add statistical tracing on
> > this tracer, but I would need a hashtable, or an array, or a list, or whatever
> > iterable to insert the data into the stat tracing api.
> >
> > But I don't know your projects about this... whether you wanted to use a section
> > or something else...
>
> It really depends on what we're tracing. If we're interested in just the
> allocation hotspots, a section will do just fine. However, if we're
> tracing memory footprint, we need to take into store the object pointer
> returned from kmalloc() and kmem_cache_alloc() so we can update
> call-site statistics properly upon kfree().
>
> So I suppose we need both, a section for per call-site statistics and a
> hash table for the object -> call-site mapping.
>
> Pekka
>
BTW. By looking on your needs, the statistical branch tracer and the rcu stat one,
it looks like these tracers often (if not always) need several stat files, not only
one.
Actually what I should do with stat tracing is to build a directory inside
/debugfs/tracing devoted to the several stat output a tracer need.
Which means I have to make trace_stat.c completely reentrant and some other
things....plus the fact that multiple tracers should be enable to run concurrently
for 2.6.30... which means one directory of stat tracing for each running tracer.
next prev parent reply other threads:[~2008-12-30 14:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 21:42 [PATCH] tracing/kmemtrace: normalize the raw tracer event to the unified tracing API Frederic Weisbecker, Frederic Weisbecker
2008-12-29 21:46 ` Frederic Weisbecker
2008-12-29 22:09 ` Frederic Weisbecker
2008-12-29 22:13 ` Frederic Weisbecker
2008-12-30 7:49 ` Pekka Enberg
2008-12-30 8:01 ` Eduard - Gabriel Munteanu
2008-12-30 8:16 ` Ingo Molnar
2008-12-30 8:41 ` Eduard - Gabriel Munteanu
2008-12-30 8:47 ` Ingo Molnar
2008-12-30 9:01 ` Pekka Enberg
2008-12-30 9:11 ` Ingo Molnar
2008-12-30 14:16 ` Frederic Weisbecker
2008-12-30 15:37 ` Ingo Molnar
2008-12-30 21:09 ` Frederic Weisbecker
2008-12-30 14:32 ` Frederic Weisbecker [this message]
2008-12-30 8:00 ` Ingo Molnar
2008-12-30 7:34 ` Ingo Molnar
2008-12-30 7:45 ` Ingo Molnar
2009-01-05 16:48 ` Steven Rostedt
2009-01-05 23:50 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081230143221.GC5722@nowhere \
--to=fweisbec@gmail.com \
--cc=eduard.munteanu@linux360.ro \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox