From: Arnd Bergmann <arnd@arndb.de>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Sam Ravnborg <sam@ravnborg.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] headers_check.pl: disallow extern's
Date: Wed, 31 Dec 2008 17:58:03 +0100 [thread overview]
Message-ID: <200812311758.04516.arnd@arndb.de> (raw)
In-Reply-To: <1230363816-24097-1-git-send-email-vapier@gentoo.org>
On Saturday 27 December 2008, Mike Frysinger wrote:
> +
> +sub check_prototypes
> +{
> + if ($line =~ m/^\s*extern\b/) {
> + printf STDERR "$filename:$lineno: extern's make no sense in userspace\n";
> + $ret = 1;
> + }
> +}
Unfortunately, this way you can only detect prototypes with an explicit
'extern' in them, not the equivalent form with an implicit extern.
Not sure if we can detect the other form reliably from perl.
Arnd <><
next prev parent reply other threads:[~2008-12-31 16:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-27 7:43 [PATCH] headers_check.pl: disallow extern's Mike Frysinger
2008-12-27 18:43 ` Sam Ravnborg
2008-12-27 18:54 ` Sam Ravnborg
2008-12-27 19:21 ` Mike Frysinger
2008-12-29 10:15 ` Mike Frysinger
2008-12-29 12:00 ` Sam Ravnborg
2008-12-27 19:23 ` Mike Frysinger
2008-12-31 16:58 ` Arnd Bergmann [this message]
2008-12-31 22:32 ` Mike Frysinger
2009-01-02 23:59 ` Arnd Bergmann
2009-01-03 0:05 ` Arjan van de Ven
2009-01-03 0:09 ` Arnd Bergmann
2009-01-03 1:20 ` Mike Frysinger
2009-01-03 1:40 ` Arnd Bergmann
2009-01-03 1:51 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812311758.04516.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox