From: Arnd Bergmann <arnd@arndb.de>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Sam Ravnborg <sam@ravnborg.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] headers_install.pl: autoconvert asm/inline/volatile to __xxx__
Date: Wed, 31 Dec 2008 18:15:07 +0100 [thread overview]
Message-ID: <200812311815.09031.arnd@arndb.de> (raw)
In-Reply-To: <1230364498-31620-1-git-send-email-vapier@gentoo.org>
On Saturday 27 December 2008, Mike Frysinger wrote:
> Headers in userspace should be using the __xxx__ form of the asm, inline,
> and volatile keywords. Since people like to revert these things without
> realizing what's going on, have the headers install step autoconvert these
> keywords.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
The patch looks right, but I would argue that most of the instances of
any of these should not be exported in the first place. I'm not
sure whether there is a legitimate use for the byteorder inlines,
but the others I could find look like they are not meant for use by the
kernel.
Arnd <><
next prev parent reply other threads:[~2008-12-31 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-27 7:54 [PATCH] headers_install.pl: autoconvert asm/inline/volatile to __xxx__ Mike Frysinger
2008-12-27 8:23 ` [PATCH v2] " Mike Frysinger
2008-12-27 18:56 ` Sam Ravnborg
2008-12-29 10:33 ` [PATCH] " H. Peter Anvin
2008-12-29 10:54 ` Mike Frysinger
2008-12-31 17:15 ` Arnd Bergmann [this message]
2008-12-31 22:34 ` Mike Frysinger
2009-01-02 23:20 ` Arnd Bergmann
2009-01-03 1:24 ` Mike Frysinger
2009-01-03 2:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812311815.09031.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox