From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755807AbZAAC0g (ORCPT ); Wed, 31 Dec 2008 21:26:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753142AbZAAC02 (ORCPT ); Wed, 31 Dec 2008 21:26:28 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:52601 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752451AbZAAC01 (ORCPT ); Wed, 31 Dec 2008 21:26:27 -0500 Date: Wed, 31 Dec 2008 18:26:13 -0800 From: Andrew Morton To: Tetsuo Handa Cc: linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [mmotm 2008-12-30-16-05] Warning at MPT driver initialization. Message-Id: <20081231182613.a37eab90.akpm@linux-foundation.org> In-Reply-To: <200901011051.ICE39590.JOFQLHFtSFMVOO@I-love.SAKURA.ne.jp> References: <200812310006.mBV060iV029753@imap1.linux-foundation.org> <200901011051.ICE39590.JOFQLHFtSFMVOO@I-love.SAKURA.ne.jp> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Jan 2009 10:51:12 +0900 Tetsuo Handa wrote: > Hello. > > I got below warning. > > Regards. > ---------------------------------------- > Fusion MPT base driver 3.04.07 > Copyright (c) 1999-2008 LSI Corporation > Fusion MPT SPI Host driver 3.04.07 > ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 11 > PCI: setting IRQ 11 as level-triggered > mptspi 0000:00:10.0: PCI INT A -> Link[LNKB] -> GSI 11 (level, low) -> IRQ 11 > mptbase: ioc0: Initiating bringup > ioc0: LSI53C1030 B0: Capabilities={Initiator} > ODEBUG: object is on stack, but not annotated > ------------[ cut here ]------------ > WARNING: at lib/debugobjects.c:253 __debug_object_init+0x1f3/0x276() > Hardware name: VMware Virtual Platform > Modules linked in: mptspi(+) mptscsih mptbase scsi_transport_spi ext3 jbd mbcache > Pid: 540, comm: insmod Not tainted 2.6.28-mm1 #2 > Call Trace: > [] warn_slowpath+0x74/0x8a > [] ? start_critical_timing+0x96/0xb7 > [] ? _spin_unlock_irqrestore+0x2f/0x3c > [] ? trace_hardirqs_off_caller+0x18/0xaf > [] ? trace_hardirqs_off+0xb/0xd > [] ? _spin_unlock_irqrestore+0x2f/0x3c > [] ? release_console_sem+0x1a5/0x1ad > [] __debug_object_init+0x1f3/0x276 > [] debug_object_init+0x13/0x17 > [] init_timer+0x10/0x1a > [] mpt_config+0x1c1/0x2b7 [mptbase] > [] ? kmalloc+0x8/0xa [mptbase] > [] ? kmalloc+0x8/0xa [mptbase] > [] mpt_do_ioc_recovery+0x950/0x1212 [mptbase] > [] ? __lock_acquire+0xa69/0xacc > [] ? _spin_unlock_irqrestore+0x36/0x3c > [] ? _spin_unlock_irq+0x22/0x26 > [] ? string+0x2b/0x76 > [] ? vsnprintf+0x338/0x7b3 > [] ? __lock_acquire+0xa69/0xacc > [] ? _spin_unlock_irqrestore+0x2f/0x3c > [] ? __lock_acquire+0xa69/0xacc > [] ? debug_check_no_locks_freed+0xeb/0x105 > [] ? _spin_unlock_irqrestore+0x36/0x3c > [] ? debug_check_no_locks_freed+0x2a/0x105 > [] ? lock_release_holdtime+0x43/0x48 > [] ? up_read+0x16/0x29 > [] ? pci_get_slot+0x66/0x72 > [] mpt_attach+0x881/0x9b1 [mptbase] > [] mptspi_probe+0x11/0x354 [mptspi] Well it's the debugobjects stuff complaining about init_timer(&pCfg->timer) in mpt_config(). I spent a minute trying to work out what the heck debug_object_is_on_stack() is trying to tell me, but it seems that code was designed to only be used by Thomas, so let's cc him and ask. Thomas, could we have some nice code comments please, so that random kernel developers don't need to go and reverse engineer the debugobjects design before they can work out what they did wrong?