* [PATCH -tip] cpumask: fix compile error in kernel/irq/proc.c
@ 2008-12-31 8:59 Li Zefan
2008-12-31 11:06 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Li Zefan @ 2008-12-31 8:59 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Rusty Russell, Mike Travis, LKML
Impact: Fix compile error
Pass correct argument type to is_affinity_mask_valid().
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
kernel/irq/proc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
index 2abd3a7..5a5ac60 100644
--- a/kernel/irq/proc.c
+++ b/kernel/irq/proc.c
@@ -111,7 +111,7 @@ static ssize_t default_affinity_write(struct file *file,
if (err)
goto out;
- if (!is_affinity_mask_valid(new_value)) {
+ if (!is_affinity_mask_valid(*new_value)) {
err = -EINVAL;
goto out;
}
--
1.5.4.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -tip] cpumask: fix compile error in kernel/irq/proc.c
2008-12-31 8:59 [PATCH -tip] cpumask: fix compile error in kernel/irq/proc.c Li Zefan
@ 2008-12-31 11:06 ` Rusty Russell
2008-12-31 11:55 ` Mike Travis
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2008-12-31 11:06 UTC (permalink / raw)
To: Li Zefan; +Cc: Ingo Molnar, Mike Travis, LKML
On Wednesday 31 December 2008 19:29:06 Li Zefan wrote:
> diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
> index 2abd3a7..5a5ac60 100644
> --- a/kernel/irq/proc.c
> +++ b/kernel/irq/proc.c
> @@ -111,7 +111,7 @@ static ssize_t default_affinity_write(struct file *file,
> if (err)
> goto out;
>
> - if (!is_affinity_mask_valid(new_value)) {
> + if (!is_affinity_mask_valid(*new_value)) {
> err = -EINVAL;
> goto out;
> }
This looks like one for Mike: I have *new_value in the cpumask tree.
Mike?
Thanks,
Rusty.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -tip] cpumask: fix compile error in kernel/irq/proc.c
2008-12-31 11:06 ` Rusty Russell
@ 2008-12-31 11:55 ` Mike Travis
0 siblings, 0 replies; 3+ messages in thread
From: Mike Travis @ 2008-12-31 11:55 UTC (permalink / raw)
To: Rusty Russell; +Cc: Li Zefan, Ingo Molnar, LKML
Rusty Russell wrote:
> On Wednesday 31 December 2008 19:29:06 Li Zefan wrote:
>> diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
>> index 2abd3a7..5a5ac60 100644
>> --- a/kernel/irq/proc.c
>> +++ b/kernel/irq/proc.c
>> @@ -111,7 +111,7 @@ static ssize_t default_affinity_write(struct file *file,
>> if (err)
>> goto out;
>>
>> - if (!is_affinity_mask_valid(new_value)) {
>> + if (!is_affinity_mask_valid(*new_value)) {
>> err = -EINVAL;
>> goto out;
>> }
>
> This looks like one for Mike: I have *new_value in the cpumask tree.
>
> Mike?
>
> Thanks,
> Rusty.
I have the old value, but then I don't have any affinity changes in my
tree. Aren't those all in your cpumask tree?
Thanks,
Mike
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-31 11:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-31 8:59 [PATCH -tip] cpumask: fix compile error in kernel/irq/proc.c Li Zefan
2008-12-31 11:06 ` Rusty Russell
2008-12-31 11:55 ` Mike Travis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox