From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F170C433F5 for ; Thu, 17 Mar 2022 22:35:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229687AbiCQWgY convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2022 18:36:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbiCQWgW (ORCPT ); Thu, 17 Mar 2022 18:36:22 -0400 Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA3ACE885E for ; Thu, 17 Mar 2022 15:35:03 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 9F3756081112; Thu, 17 Mar 2022 23:35:01 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id nVRRisT8TJYL; Thu, 17 Mar 2022 23:35:01 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 3C6A56081110; Thu, 17 Mar 2022 23:35:01 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id r1KNl6A7pLtB; Thu, 17 Mar 2022 23:35:01 +0100 (CET) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 180AA6089354; Thu, 17 Mar 2022 23:35:01 +0100 (CET) Date: Thu, 17 Mar 2022 23:35:00 +0100 (CET) From: Richard Weinberger To: libaokun Cc: linux-mtd , linux-kernel , yukuai3 , chengzhihao1 Message-ID: <2008739324.156347.1647556500875.JavaMail.zimbra@nod.at> In-Reply-To: References: <20220215040736.2839939-1-libaokun1@huawei.com> <157336576.152785.1647468012272.JavaMail.zimbra@nod.at> Subject: Re: [PATCH -next] ubifs: rename_whiteout: correct old_dir size computing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: ubifs: rename_whiteout: correct old_dir size computing Thread-Index: CY5uA77SPI4VOph1RsZDxVqHFhcrLg== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "libaokun" >>>> + >>>> + /* Add the old_dentry size to the old_dir size. */ >>>> + old_sz -= CALC_DENT_SIZE(fname_len(&old_nm)); >> So you basically reset old_sz back to 0? > Yes, reset old_sz to 0 here. Okay, makes sense. Patch applied. Thanks, //richard