From: Al Viro <viro@ZenIV.linux.org.uk>
To: Duane Griffin <duaneg@dghda.com>
Cc: Evgeniy Dushistov <dushistov@mail.ru>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ufs: don't truncate longer ufs2 fast symlinks
Date: Thu, 1 Jan 2009 02:32:32 +0000 [thread overview]
Message-ID: <20090101023232.GC28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1230742208-23972-2-git-send-email-duaneg@dghda.com>
On Wed, Dec 31, 2008 at 04:50:06PM +0000, Duane Griffin wrote:
> } else {
> - for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4; i++)
> + for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4 * 2; i++)
> ufsi->i_u1.i_symlink[i] = ufs2_inode->ui_u2.ui_symlink[i];
a) that probably ought to be a memcpy()
b) max len is superblock parameter and you've even validated it. Why don't
you use it?
> - for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4; i++)
> + for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4 * 2; i++)
> ufs_inode->ui_u2.ui_symlink[i] = ufsi->i_u1.i_symlink[i];
Ditto.
next prev parent reply other threads:[~2009-01-01 2:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 16:50 [PATCH 1/4] ufs: validate maximum fast symlink size from superblock Duane Griffin
2008-12-31 16:50 ` [PATCH 2/4] ufs: don't truncate longer ufs2 fast symlinks Duane Griffin
2008-12-31 16:50 ` [PATCH 3/4] ufs: ensure fast symlinks are NUL-terminated Duane Griffin
2008-12-31 16:50 ` [PATCH 4/4] ufs: copy symlink data into the correct union member Duane Griffin
2009-01-01 2:36 ` Al Viro
2009-01-02 14:17 ` Duane Griffin
2009-01-01 2:32 ` Al Viro [this message]
2009-01-02 14:09 ` [PATCH 2/4] ufs: don't truncate longer ufs2 fast symlinks Duane Griffin
2009-01-04 19:15 ` [PATCH 1/4] ufs: validate maximum fast symlink size from superblock Evgeniy Dushistov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090101023232.GC28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=duaneg@dghda.com \
--cc=dushistov@mail.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox