public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: Andreas Mohr <andi@lisas.de>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>,
	ath5k-devel@venema.h4ckr.net, linux-kernel@vger.kernel.org
Subject: Re: [ath5k-devel] Bugs on aspire one A150
Date: Thu, 1 Jan 2009 10:09:57 -0500	[thread overview]
Message-ID: <20090101150957.GA14921@hash.localnet> (raw)
In-Reply-To: <20090101134100.GA4819@rhlx01.hs-esslingen.de>

On Thu, Jan 01, 2009 at 02:41:00PM +0100, Andreas Mohr wrote:
> I believe the 80211 layer itself should provide some generic LED
> handling which then provide for reliable and _identical_ displaying of
> mess with custom rssi-indicating LED type implementations,
> this should be centralized to have one template for an RSSI LED.

Agreed, I suggested this in another thread.  I don't have any LEDs so it 
would be better if someone else did the work.  (I should really build a 
little usb->serial device with a couple of lights on it and hook it up
to the triggers so I can pretend...)

> More notes:
>  checks of AR5K_NUM_GPIO most certainly are buggy: off-by-1
>   (range sems to be 0-5, _not_ 1-6)

Nice catch, that has been there since day 0.

>  prepend "Acer" to "Aspire One" in this patch

Will do and I'll invert the logic level in the resend.  Thanks for the
feedback.

-- 
Bob Copeland %% www.bobcopeland.com


  parent reply	other threads:[~2009-01-01 15:10 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-08  3:26 Bugs on aspire one A150 Maxim Levitsky
2008-11-08 11:57 ` Alan Jenkins
2008-11-09  0:52   ` Maxim Levitsky
2008-11-09  8:54     ` [alsa-devel] " Takashi Iwai
2008-11-09 13:31       ` Andreas Mohr
2008-11-09 15:13       ` Andreas Mohr
2008-11-09 18:58         ` Takashi Iwai
2008-11-09 20:09           ` Andreas Mohr
2008-11-12 11:08             ` Takashi Iwai
2008-11-12 17:07               ` Maxim Levitsky
2008-11-12 18:05                 ` Andreas Mohr
2008-11-14 18:05                   ` Maxim Levitsky
2008-11-22 19:00                     ` Maxim Levitsky
2008-11-22 19:43                       ` Andreas Mohr
2008-11-24 14:35                       ` Takashi Iwai
2009-03-15  9:21                         ` Andreas Mohr
2009-03-16 12:03                           ` Andreas Mohr
2009-03-16 12:09                             ` Takashi Iwai
2009-03-16 13:30                               ` Andreas Mohr
2009-03-16 14:18                                 ` Takashi Iwai
2009-03-16 14:31                                   ` Andreas Mohr
2009-03-16 14:42                                     ` Takashi Iwai
2009-03-16 14:50                                       ` Andreas Mohr
2009-03-16 15:34                                         ` Takashi Iwai
2009-03-16 16:02                                           ` Andreas Mohr
2009-03-16 16:06                                             ` Takashi Iwai
2009-03-16 16:19                                               ` Takashi Iwai
2009-03-16 17:00                                                 ` Andreas Mohr
2009-03-16 17:15                                                   ` Takashi Iwai
2009-03-16 17:30                                                     ` Andreas Mohr
2009-03-16 17:34                                                       ` Takashi Iwai
2009-03-16 18:06                                                         ` Andreas Mohr
2009-03-16 20:28                                                           ` Takashi Iwai
2009-03-16 21:22                                                             ` Andreas Mohr
2009-03-17  0:52                                                               ` Maxim Levitsky
2009-03-17  7:57                                                                 ` Takashi Iwai
2009-03-17 11:30                                                                   ` Maxim Levitsky
2009-03-17 12:52                                                                     ` Takashi Iwai
2009-03-17  7:57                                                               ` Takashi Iwai
2009-03-17 10:05                                                                 ` Andreas Mohr
2009-03-17 10:38                                                                   ` Andreas Mohr
2009-03-17 10:47                                                                     ` Andreas Mohr
2009-03-17 11:25                                                                       ` Takashi Iwai
2009-03-17 16:18                                                                         ` Andreas Mohr
2009-03-17 20:32                                                                           ` Takashi Iwai
2009-03-18  9:05                                                                             ` Andreas Mohr
2009-03-18  9:19                                                                               ` Takashi Iwai
2009-03-20 18:56                                                                                 ` Andreas Mohr
2009-03-20 20:33                                                                                   ` Takashi Iwai
2009-03-22 12:55                                                                                     ` Andreas Mohr
2009-03-23  6:51                                                                                       ` Takashi Iwai
2008-11-12 17:20               ` Maxim Levitsky
2008-11-12 18:53               ` HDA-emu 0.0.1 (Re: [alsa-devel] Bugs on aspire one A150) Takashi Iwai
2008-11-09 10:43     ` Bugs on aspire one A150 Alan Jenkins
2008-11-12 17:48       ` Maxim Levitsky
2008-11-14 19:06   ` Maxim Levitsky
2008-11-14 19:59     ` Alan Jenkins
2008-11-15 12:52       ` Maxim Levitsky
2008-11-15 12:55         ` Matthew Garrett
2008-11-10 16:51 ` Bob Copeland
2008-11-10 21:33   ` Maxim Levitsky
2008-11-10 22:12     ` [ath5k-devel] " Nick Kossifidis
2008-11-12 17:51       ` Maxim Levitsky
2008-11-13 14:58         ` Bob Copeland
2008-11-14  3:47         ` Bob Copeland
2008-11-14 18:57           ` Maxim Levitsky
2008-11-17 17:28             ` Bob Copeland
2008-11-17 18:55               ` Maxim Levitsky
2008-12-01 15:33       ` Maxim Levitsky
2008-12-13 13:28       ` Maxim Levitsky
2008-12-13 14:08         ` Nick Kossifidis
2008-12-13 14:36           ` Maxim Levitsky
2008-12-13 14:38             ` Maxim Levitsky
2008-12-13 14:24         ` Bob Copeland
2008-12-13 14:31           ` Maxim Levitsky
2008-12-30  4:26           ` Bob Copeland
2008-12-30 12:43             ` Maxim Levitsky
2008-12-31  9:18               ` Andreas Mohr
2008-12-31 13:59                 ` Andreas Mohr
2008-12-31 14:06                   ` Bob Copeland
2008-12-31 14:03                 ` Bob Copeland
2008-12-31 16:51                   ` Maxim Levitsky
2009-01-01 13:41                     ` Andreas Mohr
2009-01-01 14:15                       ` Maxim Levitsky
2009-01-01 20:27                         ` Andreas Mohr
2009-01-01 15:09                       ` Bob Copeland [this message]
2008-12-13 13:15 ` Maxim Levitsky
2008-12-13 13:35   ` Rafael J. Wysocki
2008-12-13 14:21     ` Maxim Levitsky
2008-12-13 17:42       ` Rafael J. Wysocki
2008-12-13 18:04         ` Maxim Levitsky
2008-12-14 22:29   ` J.A. Magallón
2008-12-14 22:57   ` J.A. Magallón
2008-12-14 23:18     ` Maxim Levitsky
2008-12-14 23:24       ` J.A. Magallón
2008-12-14 23:35   ` J.A. Magallón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090101150957.GA14921@hash.localnet \
    --to=me@bobcopeland.com \
    --cc=andi@lisas.de \
    --cc=ath5k-devel@venema.h4ckr.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox