* [PATCH] Missing v4l2_prio_close in radio_release
@ 2009-01-02 5:41 Udo A. Steinberg
0 siblings, 0 replies; only message in thread
From: Udo A. Steinberg @ 2009-01-02 5:41 UTC (permalink / raw)
To: Linux Kernel Mailing List, mchehab; +Cc: v4l-dvb-maintainer, video4linux-list
[-- Attachment #1: Type: text/plain, Size: 846 bytes --]
The radio_release function of the BTTV driver is missing a call to
v4l2_prio_close. As a result, after the radio device has been opened at
least once (e.g., by HAL during bootup), v4l2_priority will never drop below
V4L2_PRIORITY_INTERACTIVE again. With the following patch against 2.6.28,
applications that run with V4L2_PRIORITY_BACKGROUND are able to open devices
again. Previous Linux versions are affected as well.
Signed-off-by: Udo Steinberg <udo@hypervisor.org>
--- linux-2.6.28/drivers/media/video/bt8xx/bttv-driver.c 2008-10-10 00:13:53.000000000 +0200
+++ linux-2.6.28/drivers/media/video/bt8xx/bttv-driver.new 2009-01-02 06:23:38.000000000 +0100
@@ -3473,6 +3474,7 @@
struct bttv *btv = fh->btv;
struct rds_command cmd;
+ v4l2_prio_close(&btv->prio,&fh->prio);
file->private_data = NULL;
kfree(fh);
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-01-02 6:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-02 5:41 [PATCH] Missing v4l2_prio_close in radio_release Udo A. Steinberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox