From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de,
Cyrill Gorcunov <gorcunov@openvz.org>,
William Irwin <wli@holomorphy.com>
Subject: Re: [patch 2/3] mm: hugetlb -- get rid of redundant if operation
Date: Fri, 2 Jan 2009 10:22:21 +0100 [thread overview]
Message-ID: <20090102092221.GA1975@elte.hu> (raw)
In-Reply-To: <495dd169.0405560a.0ebf.ffff938c@mx.google.com>
Andrew Cc:-ed.
patch looks correct to me.
Reviewed-by: Ingo Molnar <mingo@elte.hu>
Ingo
* Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> At this point we already know that 'addr' is not NULL
> so get rid of redundant 'if'. Probably gcc eliminate it
> by optimization pass.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> CC: William Irwin <wli@holomorphy.com>
> ---
> mm/hugetlb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: linux-2.6.git/mm/hugetlb.c
> ===================================================================
> --- linux-2.6.git.orig/mm/hugetlb.c
> +++ linux-2.6.git/mm/hugetlb.c
> @@ -991,8 +991,7 @@ __attribute__((weak)) int alloc_bootmem_
> * puts them into the mem_map).
> */
> m = addr;
> - if (m)
> - goto found;
> + goto found;
> }
> hstate_next_node(h);
> nr_nodes--;
>
> --
next prev parent reply other threads:[~2009-01-02 9:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090102082717.810810508@gmail.com>
2009-01-02 8:27 ` [patch 1/3] early_printk - use sizeof instead of hardcoded number Cyrill Gorcunov
2009-01-02 8:27 ` [patch 2/3] mm: hugetlb -- get rid of redundant if operation Cyrill Gorcunov
2009-01-02 9:22 ` Ingo Molnar [this message]
2009-01-02 8:27 ` [patch 3/3] acpi: check for pxm_to_node_map overflow Cyrill Gorcunov
2009-01-02 9:23 ` Ingo Molnar
2009-01-02 10:25 ` Cyrill Gorcunov
2009-01-02 10:30 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090102092221.GA1975@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox