From: Mike Frysinger <vapier@gentoo.org>
To: Andreas Schwab <schwab@suse.de>
Cc: linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
David Woodhouse <dwmw2@infradead.org>,
Jan Engelhardt <jengelh@computergmbh.de>,
Patrick McHardy <kaber@trash.net>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] linux/types.h: always export 64bit aligned defines
Date: Fri, 2 Jan 2009 15:47:30 -0500 [thread overview]
Message-ID: <200901021547.32666.vapier@gentoo.org> (raw)
In-Reply-To: <je4p0hhjko.fsf@sykes.suse.de>
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
On Friday 02 January 2009 09:24:39 Andreas Schwab wrote:
> Mike Frysinger <vapier@gentoo.org> writes:
> > These these defines dont actually conflict with normal userspace / C
> > library types, there's no reason to hide them behind the
> > __KERNEL_STRICT_NAMES define.
>
> aligned_u64 would pollute the name space, wouldn't it?
if by "pollute the name space" you mean "it'll be defined where it normally
wasnt before", then yes. it's always been in the header, just behind
__KERNEL_STRICT_NAMES. i also highlight the fact that existing headers that
are exported to userspace are already using this type, so they're broken most
of the time today.
unless you want a completely new patch that deletes aligned_*64 types and
replaces them with __aligned_*64 types ...
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2009-01-02 20:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-02 8:39 [PATCH v2] linux/types.h: always export 64bit aligned defines Mike Frysinger
2009-01-02 14:24 ` Andreas Schwab
2009-01-02 20:47 ` Mike Frysinger [this message]
2009-01-02 21:59 ` Andreas Schwab
2009-01-02 22:06 ` Mike Frysinger
2009-01-02 22:53 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901021547.32666.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=jengelh@computergmbh.de \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox