public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Ravikiran G Thirumalai <kiran@scalex86.org>
Cc: linux-kernel@vger.kernel.org, travis@sgi.com, stable@kernel.org,
	shai@scalex86.org
Subject: Re: [patch] x86: Fix incorrect __read_mostly on _boot_cpu_pda
Date: Fri, 2 Jan 2009 20:20:58 +0100	[thread overview]
Message-ID: <20090102192058.GD14249@elte.hu> (raw)
In-Reply-To: <20090102185524.GB6856@localdomain>


* Ravikiran G Thirumalai <kiran@scalex86.org> wrote:

> On Fri, Jan 02, 2009 at 05:09:51PM +0100, Ingo Molnar wrote:
> >
> >* Ravikiran G Thirumalai <kiran@scalex86.org> wrote:
> >
> >> The pda rework (commit 3461b0af025251bbc6b3d56c821c6ac2de6f7209)
> >> to remove static boot cpu pdas introduced a bug.  _boot_cpu_pda is the
> >> actual pda used by the boot cpu and is definitely not "__read_mostly" and
> >> ended up polluting the read mostly section with writes.  This bug caused
> >> regression of about 8-10% on certain syscall intensive workloads.
> >> 
> >> Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
> >
> >applied to tip/x86/urgent, with a Cc: stable tag. Thanks,
> >
> 
> Thanks!
> 
> Stable maintainers, please consider this for 2.6.27 stable as well (in 
> addition to 28).  (Attaching the tip/x86/urgent commit as reference to 
> the patch)

i have added a -stable tag to the commit - please only put it into -stable 
once it hits Linus's tree. (in the next couple of days)

> 
	Ingo

      reply	other threads:[~2009-01-02 19:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-31 21:44 [patch] x86: Fix incorrect __read_mostly on _boot_cpu_pda Ravikiran G Thirumalai
2008-12-31 22:18 ` Mike Travis
2009-01-02 16:09 ` Ingo Molnar
2009-01-02 18:55   ` Ravikiran G Thirumalai
2009-01-02 19:20     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090102192058.GD14249@elte.hu \
    --to=mingo@elte.hu \
    --cc=kiran@scalex86.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shai@scalex86.org \
    --cc=stable@kernel.org \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox