From: Sam Ravnborg <sam@ravnborg.org>
To: Len Brown <lenb@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-acpi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [incremental-PATCH-for-Sam's-Review] ACPI: use ccflags-y instead of EXTRA_CFLAGS
Date: Fri, 2 Jan 2009 22:52:08 +0100 [thread overview]
Message-ID: <20090102215208.GA8494@uranus.ravnborg.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0901021636050.3590@localhost.localdomain>
On Fri, Jan 02, 2009 at 04:44:02PM -0500, Len Brown wrote:
> From: Len Brown <len.brown@intel.com>
>
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
> drivers/acpi/Makefile | 11 ++---------
> kernel/acpi/Makefile | 11 ++---------
> kernel/acpi/acpica/Makefile | 12 ++----------
> 3 files changed, 6 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
> index 5f4096d..a4c0582 100644
> --- a/drivers/acpi/Makefile
> +++ b/drivers/acpi/Makefile
> @@ -2,15 +2,8 @@
> # Makefile for the Linux ACPI Drivers
> #
>
> -export ACPI_CFLAGS
> -
> -ACPI_CFLAGS := -Os
> -
> -ifdef CONFIG_ACPI_DEBUG
> - ACPI_CFLAGS += -DACPI_DEBUG_OUTPUT
> -endif
> -
> -EXTRA_CFLAGS += $(ACPI_CFLAGS)
> +ccflags-y := -Os
> +ccflags-$(CONFIG_ACPI_DEBUG) += -DACPI_DEBUG_OUTPUT
The conversion from ACPI_CFLAGS to ccflags-y is fine.
And if acpi really require -Os then this part is also OK -
I just did not get *why* acpi needs -Os
On the assumption the the -Os requirement is a hard requirement:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
[For the full patch - I just quoted the first part]
Sam
next prev parent reply other threads:[~2009-01-02 21:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 10:51 RFC - ACPI source code re-org Len Brown
2008-12-31 10:51 ` [PATCH 01/15] ACPI: create kernel/acpi/ Len Brown
2008-12-31 10:51 ` [PATCH 02/15] ACPI: delete include/acpi/platform/ Len Brown
2008-12-31 10:51 ` [PATCH 03/15] ACPICA: move common private headers under kernel/acpi/acpica/ Len Brown
2009-01-02 19:14 ` Ingo Molnar
2009-01-02 20:48 ` Len Brown
2009-01-07 22:10 ` Ingo Molnar
2009-01-08 16:03 ` Christoph Hellwig
2009-01-09 4:34 ` Len Brown
2009-01-11 4:09 ` Ingo Molnar
2009-01-02 21:56 ` Len Brown
2008-12-31 10:51 ` [PATCH 04/15] ACPICA: acdebug.h is private Len Brown
2008-12-31 10:51 ` [PATCH 05/15] ACPICA: delete acdisasm.h Len Brown
2008-12-31 10:51 ` [PATCH 06/15] ACPICA: acdispat.h is private Len Brown
2008-12-31 10:51 ` [PATCH 07/15] ACPICA: acevents.h " Len Brown
2008-12-31 10:51 ` [PATCH 08/15] ACPICA: acinterp.h " Len Brown
2008-12-31 10:51 ` [PATCH 09/15] ACPICA: acnamesp.h " Len Brown
2008-12-31 10:52 ` [PATCH 10/15] ACPICA: acopcode.h " Len Brown
2008-12-31 10:52 ` [PATCH 11/15] ACPICA: acparser.h " Len Brown
2008-12-31 10:52 ` [PATCH 12/15] ACPICA: acpredef.h " Len Brown
2008-12-31 10:52 ` [PATCH 13/15] ACPICA: acresrc.h, amlresrc.h are private Len Brown
2008-12-31 10:52 ` [PATCH 14/15] ACPICA: actables.h is private Len Brown
2008-12-31 10:52 ` [PATCH 15/15] ACPICA: amlcode.h " Len Brown
2008-12-31 13:39 ` [PATCH 01/15] ACPI: create kernel/acpi/ Sam Ravnborg
2008-12-31 14:21 ` Andi Kleen
2008-12-31 15:34 ` Sam Ravnborg
2009-01-02 21:44 ` [incremental-PATCH-for-Sam's-Review] ACPI: use ccflags-y instead of EXTRA_CFLAGS Len Brown
2009-01-02 21:52 ` Sam Ravnborg [this message]
2009-01-02 21:56 ` Andi Kleen
2009-01-02 22:01 ` Sam Ravnborg
2009-01-02 22:17 ` Len Brown
2009-01-02 22:46 ` Andi Kleen
2009-01-02 21:30 ` [PATCH 01/15] ACPI: create kernel/acpi/ Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090102215208.GA8494@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=andi@firstfloor.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox