Re: [PATCH] headers_install.pl: autoconvert asm/inline/volatile to __xxx__

Mike Frysinger
2008-12-31T22:34:33Z

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

On Wednesday 31 December 2008 12:15:07 Arnd Bergmann wrote:
> On Saturday 27 December 2008, Mike Frysinger wrote:
> > Headers in userspace should be using the __xxx__ form of the asm, inline,
> > and volatile keywords.  Since people like to revert these things without
> > realizing what's going on, have the headers install step autoconvert
> > these keywords.
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> The patch looks right, but I would argue that most of the instances of
> any of these should not be exported in the first place. I'm not
> sure whether there is a legitimate use for the byteorder inlines,
> but the others I could find look like they are not meant for use by the
> kernel.

maybe, but those threads are going to take quite a while to resolve and things
will constantly leak back out.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]