Re: [PATCH] headers_check.pl: disallow extern's

Mike Frysinger
2008-12-31T22:34:18Z

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

On Wednesday 31 December 2008 11:58:03 Arnd Bergmann wrote:
> On Saturday 27 December 2008, Mike Frysinger wrote:
> > +sub check_prototypes
> > +{
> > + if ($line =~ m/^\s*extern\b/) {
> > + printf STDERR "extern's make no sense in userspace\n";
> > + $ret = 1;
> > + }
> > +}
>
> Unfortunately, this way you can only detect prototypes with an explicit
> 'extern' in them, not the equivalent form with an implicit extern.
>
> Not sure if we can detect the other form reliably from perl.

yes, i already mentioned both of these issues. that's why i suggested we
start adding "extern" to all the headers (or at least the userspace ones).
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]