public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Valdis.Kletnieks@vt.edu
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.28-mmotm1230 - BUG during 'shutdown -h'
Date: Sat, 3 Jan 2009 17:43:35 +1030	[thread overview]
Message-ID: <200901031743.35578.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4491.1230900738@turing-police.cc.vt.edu>

On Friday 02 January 2009 23:22:18 Valdis.Kletnieks@vt.edu wrote:
> 100% repeatable.  I haven't had a chance to bisect and track this down yet,
> though most of the obvious suspects are in either origin.patch or linux-next.patch
> so a bisect of -mmotm probably won't tell us much.

kernel/workqueue.c: In function ‘wq_cpu_map’:
kernel/workqueue.c:94: warning: pointer type mismatch in conditional expression

That's a problem for a start.  Looks like a merge bug.  Does removing the &
from in front of cpu_populated_map help?

static const struct cpumask *wq_cpu_map(struct workqueue_struct *wq)
{
	return is_wq_single_threaded(wq)
		 ? get_cpu_mask(singlethread_cpu) : &cpu_populated_map;
}

Cheers,
Rusty.

  parent reply	other threads:[~2009-01-03  7:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-02 12:52 2.6.28-mmotm1230 - BUG during 'shutdown -h' Valdis.Kletnieks
2009-01-02 18:59 ` Andrew Morton
2009-01-03  7:13 ` Rusty Russell [this message]
2009-01-03 16:36   ` Valdis.Kletnieks
2009-01-05  6:06     ` Rusty Russell
2009-01-06  5:21       ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901031743.35578.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox