Re: [PATCH 2/2] ieee1934: dv1394 interrupt enabling/disabling broken on big-endian

Bill Fink
2009-01-04T02:18:58Z

On Sat, 03 Jan 2009, Stefan Richter wrote:

> Bill Fink wrote on 2008-12-26:
> > Good news. I finally got a chance to test the patch on my kernel,
> > and live DV viewing using xine still worked fine.
>
> Thanks a lot. If you don't mind, I'll add "Tested-by: Bill Fink
> <billfink@mindspring.com>" to the changelog when I enqueue this for
> Linus, and add a note that it actually worked for you before as well as
> after this patch.

That's fine. Although I admit to being mystified how it works both
before and after the patch, since the cpu_to_le32() calls that were
added should result in byte swapping on PPC that wasn't being done
before. I guess that either the code paths involved aren't actually
being triggered by my xine DV viewing, or there's some fortuitous
palindromic setting of bits.

-Bill