Re: [PATCH 0/4] Fastboot revisited: Asynchronous function calls

Linus Torvalds
2009-01-04T19:27:32Z

On Sun, 4 Jan 2009, Linus Torvalds wrote:
>
> Ok, so why does the serial port init take so long? That's a quarter of a
> second for you, which is ridiculous.

Hmm. I also note that you don't seem to have the IDE probing configured in
at all. It's not _that_ uncommon, afaik, and even if you have no devices
behind it (or perhaps _especially_ if you have no devices behind it), the
IDE probe is actually pretty expensive. Hmm?

Also, I'm looking at the AHCI vs Marvell thing, and the problem seems to
be that you do that libata port scan like this:

for (i = 0; i < host->n_ports; i++) {
struct ata_port *ap = host->ports[i];

async_schedule(async_port_probe, ap);
}

async_synchronize_full();
/* probes are done, now scan each port's disk(s) */
DPRINTK("host probe begin\n");
for (i = 0; i < host->n_ports; i++) {
struct ata_port *ap = host->ports[i];

ata_scsi_scan_host(ap, 1);
}

which means that there is a full serialization between each controller.

Wouldn't is be possible to move the "ata_scsi_scan_host(ap, 1);" _into_
the async_port_probe(), and just do a

async_synchronize_cookie(cookie);

before it? Hmm?

And then not do any async_synchronize_full() at all, until much later. For
example, we clearly do need that full synchronization before we try to
mount the root filesystem, but we should have that particular
synchronization regardless of any SATA issues.

I may be missing something obvious, of course. Maybe a simple cookie
synchronization isn't sufficient for some reason (most likely reason:
other SCSI drivers that don't do it).

Linus