From: Ingo Molnar <mingo@elte.hu>
To: Baodong Chen <chenbdchenbd@gmail.com>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: Subject: [PATCH] Documentation/x86/boot.txt:payload length was changed to payload_length
Date: Sun, 4 Jan 2009 13:57:13 +0100 [thread overview]
Message-ID: <20090104125713.GD15472@elte.hu> (raw)
In-Reply-To: <d204e3110901022044l2cf57f54yd52a2d331d69deef@mail.gmail.com>
* Baodong Chen <chenbdchenbd@gmail.com> wrote:
> On Fri, Jan 2, 2009 at 5:26 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Baodong Chen <chenbdchenbd@gmail.com> wrote:
> >
> >> Documentation/x86/boot.txt:payload length was changed to payload_length
> >>
> >> Signed-off-by: Baodong Chen <[email]chenbdchenbd@gmail.com[email]>
> >>
> >> ---
> >> Documentation/x86/boot.txt | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > looks good but the patch was whitespace damaged (all tabs were spaces and
> > there were linewraps as well), please check
> > Documentation/email-clients.txt and resend the patch. Thanks,
> >
> > Ingo
>
> I referred to Documentation/email-clients.txt:Gmail and resent the
> patch. I am a newbie,if i made any mistake,please do me a favor and help
> me.Thanks!
it's OK, and your resubmission was better - but it still had a linewrap
problem (i was able to fix that up manually).
this bit:
@@ -44,7 +44,7 @@ Protocol 2.07: (Kernel 2.6.24) Added paravirtualised
boot protocol.
and KEEP_SEGMENTS flag in load_flags.
[3 lines]
should have been:
@@ -44,7 +44,7 @@ Protocol 2.07: (Kernel 2.6.24) Added paravirtualised boot protocol.
and KEEP_SEGMENTS flag in load_flags.
[2 lines]
If you post from gmail it might make sense to send patches as MIME
attachments, we can process them just fine. (as long as you send patches
that go via -tip - other maintainers have different policies regarding
MIME attachments)
Ingo
next prev parent reply other threads:[~2009-01-04 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-02 8:24 Subject: [PATCH] Documentation/x86/boot.txt:payload length was changed to payload_length Baodong Chen
2009-01-02 9:26 ` Ingo Molnar
2009-01-03 4:44 ` Baodong Chen
2009-01-04 12:57 ` Ingo Molnar [this message]
2009-01-04 13:49 ` Baodong Chen
2009-01-04 13:55 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090104125713.GD15472@elte.hu \
--to=mingo@elte.hu \
--cc=chenbdchenbd@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox