From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: linux-pci@vger.kernel.org, tom.l.nguyen@intel.com,
yanmin.zhang@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aerdrv: fix sanity check in report_resume
Date: Mon, 5 Jan 2009 13:23:32 -0800 [thread overview]
Message-ID: <200901051323.32341.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <200901051303.19749.jbarnes@virtuousgeek.org>
On Monday, January 5, 2009 1:03 pm Jesse Barnes wrote:
> On Sunday, November 30, 2008 11:31 pm Hidetoshi Seto wrote:
> > What we have to check here before calling it is err_handler->resume.
> > It seems that this block have been copy&pasted from report_slot_reset.
> >
> > Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
> > ---
> > drivers/pci/pcie/aer/aerdrv_core.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/pci/pcie/aer/aerdrv_core.c
> > b/drivers/pci/pcie/aer/aerdrv_core.c index dfc63d0..aac7006 100644
> > --- a/drivers/pci/pcie/aer/aerdrv_core.c
> > +++ b/drivers/pci/pcie/aer/aerdrv_core.c
> > @@ -252,7 +252,7 @@ static void report_resume(struct pci_dev *dev, void
> > *data)
> >
> > if (!dev->driver ||
> > !dev->driver->err_handler ||
> > - !dev->driver->err_handler->slot_reset)
> > + !dev->driver->err_handler->resume)
> > return;
> >
> > err_handler = dev->driver->err_handler;
>
> Applied (again). Hope it doesn't get lost again between now & when I send
> the pull. Sorry about that.
Ah nm, I see it went through my for-linus branch, so it appears to be upstream
already.... Phew. I'm still lossy but not as lossy as I thought I was. :)
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2009-01-05 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 7:31 [PATCH] aerdrv: fix sanity check in report_resume Hidetoshi Seto
2008-12-01 7:58 ` Zhang, Yanmin
2008-12-16 18:31 ` Jesse Barnes
2009-01-05 21:03 ` Jesse Barnes
2009-01-05 21:23 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901051323.32341.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tom.l.nguyen@intel.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox