From: Ingo Molnar <mingo@elte.hu>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Yinghai Lu <yinghai@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: irqnr fallout in gpiolib on sparc32
Date: Mon, 5 Jan 2009 14:55:08 +0100 [thread overview]
Message-ID: <20090105135508.GB4190@elte.hu> (raw)
In-Reply-To: <20090105134832.GA14460@uranus.ravnborg.org>
* Sam Ravnborg <sam@ravnborg.org> wrote:
> > > I did a simple:
> > > #include <linux/irqnr.h> but that did not help.
> >
> > yeah. Does the patch below do the trick?
>
> Needed a small fix - see below.
>
> > btw., i'm curious, does the unification of the sparc architectures
> > mean that sparc32 will be using genirq too some time in the future?
>
> Dave has mentioned this but we are not working actively on it yet.
would be cool to do it - i think sparc32 is one of the last major physical
architectures to not be on genirq - if we did this conversion we could do
a good number of nice cleanups by eliminating all the genirq/non-genirq
differences.
> > +#define nr_irqs NR_IRQS
> > +#define irq_to_desc(irq) irq_desc[irq]
>
> irq_to_desc(irq) return a pointer to a struct irq_desc
> so we need to take the address.
>
> > +#define irq_to_desc(irq) &irq_desc[irq]
> ^
> With this small fix the build continues.
oops, indeed. I fixed it, added your Tested-by and pushed it into
tip/irq/urgent. Thanks Sam!
Ingo
next prev parent reply other threads:[~2009-01-05 13:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 13:29 irqnr fallout in gpiolib on sparc32 Sam Ravnborg
2009-01-05 13:38 ` Ingo Molnar
2009-01-05 13:48 ` Sam Ravnborg
2009-01-05 13:55 ` Ingo Molnar [this message]
2009-01-05 20:37 ` David Miller
2009-01-06 12:57 ` Ingo Molnar
2009-01-06 16:29 ` David Miller
2009-01-07 13:02 ` Ingo Molnar
2009-01-07 13:34 ` Sam Ravnborg
2009-01-07 21:08 ` David Miller
2009-01-06 23:43 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090105135508.GB4190@elte.hu \
--to=mingo@elte.hu \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox