From: Christoph Hellwig <hch@infradead.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Heikki Orsila <shdl@zakalwe.fi>, unsik Kim <donari75@gmail.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] mflash linux support
Date: Mon, 5 Jan 2009 12:40:26 -0500 [thread overview]
Message-ID: <20090105174026.GA1855@infradead.org> (raw)
In-Reply-To: <20090105111321.7d210c01@lxorguk.ukuu.org.uk>
On Mon, Jan 05, 2009 at 11:13:21AM +0000, Alan Cox wrote:
> On Mon, 5 Jan 2009 04:33:46 +0200
> Heikki Orsila <shdl@zakalwe.fi> wrote:
>
> > A few style issues:
>
> How about starting by worrying about the code not pointless style
> complaints ?
>
> >> > + switch (cmd) {
> > > + case HDIO_GETGEO:
> >
> > if (cmd == HDIO_GETGEO) {
>
> Especially when you are making pointless complaints about things that are
> generally done the way the original code is - and for good reason. It
> makes it far cleaner to add new ioctl support.
Or either of you could check what blkdev_ioctl() does with HDIO_GETGEO
and why this code doesn't even need to exist at all.
next prev parent reply other threads:[~2009-01-05 17:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 1:18 [PATCH] mflash linux support unsik Kim
2009-01-05 2:33 ` Heikki Orsila
2009-01-05 9:30 ` unsik Kim
2009-01-05 11:13 ` Alan Cox
2009-01-05 17:40 ` Christoph Hellwig [this message]
2009-01-06 4:37 ` unsik Kim
2009-01-05 19:26 ` [PATCH] mflash: remove small byteswapping function Harvey Harrison
2009-01-20 8:25 ` unsik Kim
2009-01-21 5:55 ` MinChan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090105174026.GA1855@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=donari75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shdl@zakalwe.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox