Re: [BUG] NULL pointer deref with rcutorture

Paul E. McKenney
2009-01-07T22:49:22Z

On Wed, Jan 07, 2009 at 11:34:12PM +0100, Eric Sesterhenn wrote:
> * Paul E. McKenney (paulmck@linux.vnet.ibm.com) wrote:
> > On Wed, Jan 07, 2009 at 09:19:04PM +0100, Eric Sesterhenn wrote:
> > > * Paul E. McKenney (paulmck@linux.vnet.ibm.com) wrote:
> > > > On Tue, Jan 06, 2009 at 04:48:09AM -0800, Paul E. McKenney wrote:
> > > > > On Tue, Jan 06, 2009 at 08:47:07AM +0100, Eric Sesterhenn wrote:
> > > > > > * Paul E. McKenney (paulmck@linux.vnet.ibm.com) wrote:
> > > > > > > On Mon, Jan 05, 2009 at 04:29:12PM -0800, Paul E. McKenney wrote:
> > > > > > > > On Mon, Jan 05, 2009 at 02:18:36PM -0800, Paul E. McKenney wrote:
> > > > > > > > I will see what I can find from this.
> > > > > > >
> > > > > > > Hello, Eric,
> > > > > > >
> > > > > > > Just for grins, I built the 2.6.28 kernel/rcutorture.c on b58602a. It
> > > > > > > insmoded and rmmoded without errors.
> > > > > > >
> > > > > > > Could you please try this on your setup? I have attached this file in
> > > > > > > case that helps.
> > > > > >
> > > > > > works like a charm
> > > > >
> > > > > Well, that certainly tells me where the bug lies. ;-)
> > > > >
> > > > > Thank you for all your hard work on this, I should have a patch soon.
> > > >
> > > > And here it is, against the original version of rcutorture.c (revert
> > > > all of my previous patches against rcutorture.c). I am also attaching
> > > > the resulting rcutorture.c, if that makes things more convenient for you.
> > > >
> > > > Could you please fire this up and see if it fixes the rmmod-time bug
> > > > that you located?
> > >
> > > it does fix the bug, thanks for your work
> >
> > Thank you very much for finding this one, bearing with me during the
> > debug process, and testing it! I will post the patch with credit to you.
> >
> > Does this fix all of the problems that you observed, or is there still
> > some breakage?
>
> It fixes everything i saw. Thanks.

Woo-hoo!!! ;-)

Thanx, Paul