From: Alasdair G Kergon <agk@redhat.com>
To: crquan@gmail.com
Cc: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>,
linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Mikulas Patocka <mpatocka@redhat.com>,
device-mapper development <dm-devel@redhat.com>,
"Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Milan Broz <mbroz@redhat.com>
Subject: Re: [dm-devel] Re: [git pull] device-mapper patches for 2.6.29
Date: Tue, 6 Jan 2009 03:48:45 +0000 [thread overview]
Message-ID: <20090106034845.GD3512@agk.fab.redhat.com> (raw)
In-Reply-To: <91b13c310901051932p1343f9eei1db5534e6e10d238@mail.gmail.com>
On Tue, Jan 06, 2009 at 11:32:51AM +0800, Cheng Renquan (程任全) wrote:
> On Tue, Jan 6, 2009 at 11:21 AM, Alasdair G Kergon <agk@redhat.com> wrote:
> > On Tue, Jan 06, 2009 at 11:15:58AM +0800, Cheng Renquan (程任全) wrote:
> >> So now maybe we can add a null macro to module_refcount if
> >> CONFIG_MODULE_UNLOAD undefined?
> > Do we even need the test at all?
> So you mean add "#ifdef CONFIG_MODULE_UNLOAD ..." to dm-target.c? I
> can do that, but I really don't know a better solution without
> conditional compiling?
I mean under what set of circumstances could the test of the module refcount
here fail, and if the test was simply removed are there any cases where that
would matter?
Alasdair
--
agk@redhat.com
next prev parent reply other threads:[~2009-01-06 3:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 12:51 [git pull] device-mapper patches for 2.6.28 Alasdair G Kergon
2009-01-05 19:18 ` [git pull] device-mapper patches for 2.6.29 Alasdair G Kergon
2009-01-06 2:51 ` Linus Torvalds
2009-01-06 3:04 ` Stephen Rothwell
2009-01-06 3:14 ` [dm-devel] " Alasdair G Kergon
2009-01-06 3:15 ` Cheng Renquan (程任全)
2009-01-06 3:21 ` Alasdair G Kergon
2009-01-06 3:32 ` Cheng Renquan (程任全)
2009-01-06 3:48 ` Alasdair G Kergon [this message]
2009-01-06 11:59 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106034845.GD3512@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=andi@firstfloor.org \
--cc=crquan@gmail.com \
--cc=dm-devel@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=k-ueda@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=mpatocka@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox