From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1754796AbZAFKII@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754796AbZAFKII (ORCPT <rfc822;w@1wt.eu>);
	Tue, 6 Jan 2009 05:08:08 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754666AbZAFKHt
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 6 Jan 2009 05:07:49 -0500
Received: from mx2.mail.elte.hu ([157.181.151.9]:43980 "EHLO mx2.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754573AbZAFKHt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 6 Jan 2009 05:07:49 -0500
Date: Tue, 6 Jan 2009 11:07:30 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Li Zefan <lizf@cn.fujitsu.com>, Rusty Russell <rusty@rustcorp.com.au>,
       Peter Zijlstra <a.p.zijlstra@chello.nl>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: fix double kfree
Message-ID: <20090106100730.GA12024@elte.hu>
References: <496326BA.60605@cn.fujitsu.com> <84144f020901060150i524a4fatdc1c2ca86ab2adab@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <84144f020901060150i524a4fatdc1c2ca86ab2adab@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-ELTE-VirusStatus: clean
X-ELTE-SpamScore: -1.5
X-ELTE-SpamLevel: 
X-ELTE-SpamCheck: no
X-ELTE-SpamVersion: ELTE 2.0 
X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3
	-1.5 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> On Tue, Jan 6, 2009 at 11:39 AM, Li Zefan <lizf@cn.fujitsu.com> wrote:
> > Impact: fix double kfree in failure path
> >
> > It's not the responsibility of init_rootdomain() to free root_domain
> > allocated by alloc_rootdomain().
> >
> > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> 
> FWIW
> 
> Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>

thanks - added it to the changelog.

	Ingo