From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, fweisbec@gmail.com,
roel.kluin@gmail.com, pq@iki.fi, srostedt@redhat.com
Subject: Re: [PATCH 3/3] tracing/ftrace: fix a memory leak in stat tracing
Date: Tue, 6 Jan 2009 14:51:57 -0800 [thread overview]
Message-ID: <20090106145157.124e910f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090106223405.703770821@goodmis.org>
On Tue, 06 Jan 2009 17:33:40 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> static int stat_seq_show(struct seq_file *s, void *v)
> {
> - struct trace_stat_list *l = list_entry(v, struct trace_stat_list, list);
> - return current_tracer.stat_show(s, l->stat);
> + struct trace_stat_list *entry =
> + list_entry(v, struct trace_stat_list, list);
> +
> + return current_tracer.stat_show(s, entry->stat);
> }
Rather than jumping through weird 80-column hoops, one can just do:
struct trace_stat_list *entry;
...
entry = list_entry(v, struct trace_stat_list, list);
next prev parent reply other threads:[~2009-01-06 22:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 22:33 [PATCH 0/3] ftrace: important updates Steven Rostedt
2009-01-06 22:33 ` [PATCH 1/3] ftrace: convert unsigned index to signed Steven Rostedt
2009-01-06 22:50 ` Andrew Morton
2009-01-07 2:42 ` Steven Rostedt
2009-01-06 22:33 ` [PATCH 2/3] ring-buffer: rename debugfs file tracing_on to writing_enabled Steven Rostedt
2009-01-06 22:47 ` Andrew Morton
2009-01-07 2:52 ` Steven Rostedt
2009-01-06 22:33 ` [PATCH 3/3] tracing/ftrace: fix a memory leak in stat tracing Steven Rostedt
2009-01-06 22:51 ` Andrew Morton [this message]
2009-01-07 2:53 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106145157.124e910f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pq@iki.fi \
--cc=roel.kluin@gmail.com \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox