Re: ftrace breaks sparc64 build

Heiko Carstens
2009-01-06T09:45:50Z

On Mon, Jan 05, 2009 at 11:30:58PM -0500, Steven Rostedt wrote:
> On Tue, 6 Jan 2009, Heiko Carstens wrote:
> Sam and Heiko,
>
> I'm trying to see if the (a ? b : c) construct is causing the issue. Can
> you test this patch.
>
> diff --git a/include/linux/compiler.h b/include/linux/compiler.h
> index d95da10..e13ad24 100644
> --- a/include/linux/compiler.h
> +++ b/include/linux/compiler.h
> @@ -113,7 +113,8 @@ void ftrace_likely_update(struct ftrace_branch_data *f, int val, int expect);
> * "Define 'is'", Bill Clinton
> * "Define 'if'", Steven Rostedt
> */
> -#define if(cond) if (__builtin_constant_p((cond)) ? !!(cond) : \
> +#define if(cond) if ((__builtin_constant_p((cond)) && !!(cond)) || \
> + (!__builtin_constant_p((cond)) && \

Doesn't help unfortunately.