Re: [PATCH] sparc: make proces_ver_nack a bit more readable

Sam Ravnborg
2009-01-05T20:06:28Z

On Mon, Jan 05, 2009 at 02:56:58PM -0500, Steven Rostedt wrote:
>
> On Mon, 5 Jan 2009, Steven Rostedt wrote:
>
> >
> > Impact: clean up
> >
> > The code in process_ver_nack is a little obfuscated. This change
> > makes it a bit more readable by humans. It removes the complex
> > if statement and replaces it with a cleaner flow of control.
> >
> > Signed-off-by: Steven Rostedt <srostedt@redhat.com>
>
> Sam,
>
> Can you test to see if this patch makes the issue go away. Obviously, Dave
> would need to be the one to pull it in, or at least ack it.

As expected the patch silence the warning.
The warning only triggers when we have an assignment
after a boolean || inside an if condition.

Sam