public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dimitri Sivanich <sivanich@sgi.com>
To: linux-ia64@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
	Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Gregory Haskins <ghaskins@novell.com>,
	Nick Piggin <npiggin@suse.de>, Tony Luck <tony.luck@gmail.com>,
	Robin Holt <holt@sgi.com>
Subject: [PATCH] configure HAVE_UNSTABLE_SCHED_CLOCK for SGI_SN systems
Date: Tue, 6 Jan 2009 10:27:41 -0600	[thread overview]
Message-ID: <20090106162741.GA7991@sgi.com> (raw)

Turn on CONFIG_HAVE_UNSTABLE_SCHED_CLOCK for SGI_SN.

SGI Altix has unsynchronized itc clocks.  This results in rq->clock
occasionally being set to a time in the past by a remote cpu.

Note that it is possible that this problem may exist for other ia64
machines as well, based on the following comment for sched_clock() in
arch/ia64/kernel/head.S:

 * Return a CPU-local timestamp in nano-seconds.  This timestamp is
 * NOT synchronized across CPUs its return value must never be
 * compared against the values returned on another CPU.  The usage in
 * kernel/sched.c ensures that.


Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>

---

Greg, if everyone is OK with this patch, this should also be applied
to all stable trees starting with 2.6.26.

 arch/ia64/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6/arch/ia64/Kconfig
===================================================================
--- linux-2.6.orig/arch/ia64/Kconfig	2009-01-06 10:13:13.051918923 -0600
+++ linux-2.6/arch/ia64/Kconfig	2009-01-06 10:13:44.547856328 -0600
@@ -536,6 +536,7 @@ config IA64_MC_ERR_INJECT
 
 config SGI_SN
 	def_bool y if (IA64_SGI_SN2 || IA64_GENERIC)
+	select HAVE_UNSTABLE_SCHED_CLOCK
 
 config IA64_ESI
 	bool "ESI (Extensible SAL Interface) support"

             reply	other threads:[~2009-01-06 16:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-06 16:27 Dimitri Sivanich [this message]
2009-01-06 17:12 ` [PATCH] configure HAVE_UNSTABLE_SCHED_CLOCK for SGI_SN systems Greg KH
2009-01-06 20:15 ` Luck, Tony
2009-01-06 20:19   ` Robin Holt
2009-01-06 20:34     ` Luck, Tony
2009-01-06 20:57       ` Peter Zijlstra
2009-01-06 22:50         ` Robin Holt
2009-01-06 23:16           ` Peter Zijlstra
2009-01-07  3:00             ` Nick Piggin
2009-01-07  3:16               ` Jack Steiner
2009-01-07  7:28               ` Peter Zijlstra
2009-01-07  7:40                 ` Nick Piggin
2009-01-07  9:43                 ` Robin Holt
2009-01-07  9:53                   ` Peter Zijlstra
2009-01-07 13:32                     ` Dimitri Sivanich
2009-01-07 15:16                       ` Peter Zijlstra
2009-01-15 18:48 ` Greg KH
2009-01-15 19:21   ` Luck, Tony
2009-01-22 19:04     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090106162741.GA7991@sgi.com \
    --to=sivanich@sgi.com \
    --cc=ghaskins@novell.com \
    --cc=greg@kroah.com \
    --cc=holt@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    --cc=peterz@infradead.org \
    --cc=tony.luck@gmail.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox