Re: linux-next: Tree for January 6 (MTD)

Alexey Korolev
2009-01-06T17:36:31Z

Hi Randy,

> # CONFIG_MTD_LPDDR is not set
> CONFIG_MTD_QINFO_PROBE=y
>
> There appears to be too little control/coordination between those
> two kconfig symbols. Surely one of them (MTD_QINFO_PROBE) should
> depend on the other (MTD_LPDDR). And why even build 2 modules
> when MTD_QINFO_PROBE is enabled? Why not combine the code into
> one module?
Thanks a lot for good finding. Here is a fix for the problem.

About combining: it is assumed to have one QINFO probing module for several
kinds of LPDDR command set drivers. If we combine two modules into
one it would make further extension rather hard. So it is better to have
two modules.
To fix a problem I just added dependency in Kconfig file.
This temporary fix which will work until we have just one cmdset module.
In near future we will make a fix which parse command set types
and select proper driver according to device type.

Thanks,
Alexey

Signed-off-by: Alexey Korolev <akorolev@infradead.org>
---
diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig
index acd4ea9..5a401d8 100644
--- a/drivers/mtd/lpddr/Kconfig
+++ b/drivers/mtd/lpddr/Kconfig
@@ -12,6 +12,7 @@ config MTD_LPDDR
DDR memories, intended for battery-operated systems.

config MTD_QINFO_PROBE
+ depends on MTD_LPDDR
tristate "Detect flash chips by QINFO probe"
help
Device Information for LPDDR chips is offered through the Overlay