From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Dmitri Monakhov <dmonakhov@openvz.org>
Subject: Re: 2.6.29 -mm merge plans
Date: Wed, 7 Jan 2009 13:16:54 +1100 [thread overview]
Message-ID: <20090107021654.GD9448@disturbed> (raw)
In-Reply-To: <20090106232208.GA25103@infradead.org>
On Tue, Jan 06, 2009 at 06:22:08PM -0500, Christoph Hellwig wrote:
> On Tue, Jan 06, 2009 at 03:08:55PM -0800, Andrew Morton wrote:
> > > Btw, this code is still not quite right. We really need to call
> > > ->setattr instead of vmtruncate here. Complex filesystem need
> > > transaction to properly free blocks, and those transactions are in
> > > ->setattr not inside vmtruncate where ->truncate doesn't even have
> > > a chance to get the handle to the transaction passed.
> > >
> > > As these patches don't make it worse this is not a NACK, but more of
> > > a heads up.
> >
> > Sure. Maybe add a FIXME comment for now?
>
> Ok. I was planning to look into this again, and IIRC Dave already did
> when he was at SGI, but his proof of concept patches got lost somewhere.
Hmmmm - I think I posted the "it works for XFs but nothing else" POC
patches to fsdevel when I first found this....
<rummage>
http://marc.info/?l=linux-fsdevel&m=120952722315259&w=2
The thread starts here for those that want the whole story:
http://marc.info/?l=linux-fsdevel&m=120946361527726&w=2
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2009-01-07 2:17 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 8:43 2.6.29 -mm merge plans Andrew Morton
2009-01-05 9:00 ` KOSAKI Motohiro
2009-01-05 9:07 ` Andrew Morton
2009-01-05 22:31 ` Ying Han
2009-01-05 22:34 ` Valdis.Kletnieks
2009-01-08 4:18 ` Ying Han
2009-01-08 4:41 ` KOSAKI Motohiro
2009-01-08 7:57 ` Ying Han
2009-01-08 8:31 ` KOSAKI Motohiro
2009-01-11 4:18 ` Valdis.Kletnieks
2009-01-12 4:18 ` Ying Han
2009-01-06 5:27 ` Valdis.Kletnieks
2009-01-06 5:41 ` Nick Piggin
2009-01-05 9:02 ` Sam Ravnborg
2009-01-05 9:12 ` Andrew Morton
2009-01-05 9:17 ` David Miller
2009-01-05 9:21 ` Ingo Molnar
2009-01-05 9:39 ` Sam Ravnborg
2009-01-05 10:10 ` Ingo Molnar
2009-01-05 10:36 ` David Miller
2009-01-05 12:32 ` Ingo Molnar
2009-01-05 10:11 ` Ingo Molnar
2009-01-05 10:37 ` David Miller
2009-01-05 9:40 ` Ryusuke Konishi
2009-01-06 13:30 ` Pekka Enberg
2009-01-07 3:26 ` Ryusuke Konishi
2009-01-07 7:58 ` Pekka Enberg
2009-01-07 14:17 ` Chris Mason
2009-01-05 11:34 ` Al Viro
2009-01-05 11:40 ` Stephen Rothwell
2008-10-06 6:14 ` Greg Ungerer
2009-01-05 12:17 ` Ingo Molnar
2009-01-05 17:38 ` KOSAKI Motohiro
2009-01-05 12:28 ` Nick Piggin
2009-01-12 22:06 ` Andrew Morton
2009-01-15 6:37 ` Nick Piggin
2009-01-06 9:46 ` Pavel Machek
2009-01-06 22:33 ` Folkert van Heusden
2009-01-06 22:38 ` Alan Cox
2009-01-06 22:57 ` Christoph Hellwig
2009-01-06 23:08 ` Andrew Morton
2009-01-07 1:05 ` Nick Piggin
2009-01-06 23:08 ` Andrew Morton
2009-01-06 23:22 ` Christoph Hellwig
2009-01-07 2:16 ` Dave Chinner [this message]
2009-01-08 15:50 ` Dmitri Monakhov
2009-01-06 23:11 ` Andrew Morton
2009-01-06 23:24 ` Christoph Hellwig
2009-01-07 1:14 ` Nick Piggin
2009-01-07 1:38 ` Andi Kleen
2009-01-07 1:49 ` Nick Piggin
2009-01-07 2:57 ` Andi Kleen
2009-01-07 3:28 ` Nick Piggin
2009-01-08 13:24 ` Pavel Machek
2009-01-10 15:07 ` Andi Kleen
2009-01-10 21:32 ` sync, reboot, and corrupting data [was Re: 2.6.29 -mm merge plans] Pavel Machek
2009-01-10 22:12 ` Andi Kleen
2009-01-10 22:26 ` Pavel Machek
2009-01-08 13:22 ` 2.6.29 -mm merge plans Pavel Machek
2009-01-06 23:13 ` Andrew Morton
2009-01-06 23:24 ` Christoph Hellwig
2009-01-06 23:38 ` Andrew Morton
2009-01-07 2:06 ` Nick Piggin
2009-01-07 2:16 ` Andrew Morton
2009-01-07 3:05 ` Nick Piggin
2009-01-07 4:16 ` Andrew Morton
2009-01-06 23:15 ` Andrew Morton
2009-01-06 23:25 ` Christoph Hellwig
2009-01-07 7:54 ` Christoph Hellwig
2009-01-07 7:59 ` Andrew Morton
2009-01-07 8:10 ` Christoph Hellwig
2009-01-06 23:17 ` Andrew Morton
2009-01-06 23:19 ` Christoph Hellwig
2009-01-06 23:26 ` Warren Turkal
2009-01-06 23:26 ` Warren Turkal
2009-01-12 3:19 ` Roman Zippel
2009-01-06 23:27 ` Diego E. 'Flameeyes' Pettenò
2009-01-06 23:31 ` Christoph Hellwig
2009-01-06 23:49 ` Harvey Harrison
2009-01-07 0:09 ` Diego E. 'Flameeyes' Pettenò
2009-01-07 0:16 ` Harvey Harrison
2009-01-12 4:21 ` Roman Zippel
2009-01-06 23:19 ` Andrew Morton
2009-01-08 19:11 ` Rodolfo Giometti
2009-01-12 20:23 ` Christoph Hellwig
2009-01-13 9:49 ` Rodolfo Giometti
2009-01-12 20:22 ` Christoph Hellwig
2009-01-13 9:47 ` Rodolfo Giometti
2009-01-06 23:21 ` Andrew Morton
2009-01-06 23:28 ` Andrew Morton
2009-01-07 2:21 ` Nick Piggin
2009-01-08 8:39 ` Miklos Szeredi
2009-01-15 6:45 ` Nick Piggin
2009-01-07 0:01 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107021654.GD9448@disturbed \
--to=david@fromorbit.com \
--cc=akpm@linux-foundation.org \
--cc=dmonakhov@openvz.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox