Re: [GIT PATCH] USB patches for 2.6-git

Linus Torvalds
2008-10-17T22:48:36Z

On Fri, 17 Oct 2008, Greg KH wrote:
>
> Here is the big batch of USB patches for your 2.6-git tree.

I really wish I were to get the occasional _clean_ pull for a change.

f*ck me, but why do people keep adding more and more warnings, and
apparently not even bother to write clean code? The merge window is no
excuse for badly written crap.

drivers/usb/host/ehci-hcd.c: In function ‘ehci_hcd_init’:
drivers/usb/host/ehci-hcd.c:1115: warning: label ‘err_debug’ defined but not used

That particular function is just about the ugliest thing I've ever seen,
and now it's adding annoying warnings too!

Yeah, I'm grumpy. The quality control during this merge window has been
absolutely disgusting. I feel like I have to complain about every other
pull I do, because people feel like another new warning isn't a problem.
And every single time, the new warning is due to some total crap code.

Linus