Re: [GIT PATCH] USB patches for 2.6-git

Greg KH
2008-10-17T23:03:55Z

On Fri, Oct 17, 2008 at 03:47:58PM -0700, Linus Torvalds wrote:
>
>
> On Fri, 17 Oct 2008, Greg KH wrote:
> >
> > Here is the big batch of USB patches for your 2.6-git tree.
>
> I really wish I were to get the occasional _clean_ pull for a change.
>
> f*ck me, but why do people keep adding more and more warnings, and
> apparently not even bother to write clean code? The merge window is no
> excuse for badly written crap.
>
> drivers/usb/host/ehci-hcd.c: In function ‘ehci_hcd_init’:
> drivers/usb/host/ehci-hcd.c:1115: warning: label ‘err_debug’ defined but not used

Why am I not seeing that warning here?

ah, because I have debugging for USB enabled in my configuration, sorry
about that, I should have caught that. That's the problem with doing a
'make allyesconfig' as a test build, I need to make it random at times
to catch things like this.

> That particular function is just about the ugliest thing I've ever seen,
> and now it's adding annoying warnings too!

I agree, it's always been ugly, sorry for making it worse. I'll move
that label up one line and fix the warning.

thanks,

greg k-h